aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2017-12-19 23:39:24 +0100
committerGravatar Lubomir I. Ivanov <neolit123@gmail.com>2017-12-21 00:04:30 +0100
commit22dc7b84f091b392537ab51539c4277ad54416de (patch)
treefe89edcfd435e886f20be9ba719fcdc413080f26
parent0b2d22494c649205442c09318ae7503c818b22d2 (diff)
downloadsubsurface-22dc7b84f091b392537ab51539c4277ad54416de.tar.gz
Handle plot_info->nr <= 0 gracefully
plot_info->nr should always be > 0. If this is not the case, write a message to stderr instead of crashing in add_plot_pressure(). This silences an use-of-uninitialized-variable warning. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r--core/profile.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/core/profile.c b/core/profile.c
index 327956cd5..e463c9c2b 100644
--- a/core/profile.c
+++ b/core/profile.c
@@ -805,6 +805,10 @@ static void populate_secondary_sensor_data(struct divecomputer *dc, struct plot_
static void add_plot_pressure(struct plot_info *pi, int time, int cyl, pressure_t p)
{
struct plot_data *entry;
+ if (pi->nr <= 0) {
+ fprintf(stderr, "add_plot_pressure(): called with pi->nr <= 0\n");
+ return;
+ }
for (int i = 0; i < pi->nr; i++) {
entry = pi->entry + i;