aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2020-03-30 20:31:28 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2020-03-30 13:58:10 -0700
commit38d70ba8545e9c97c60d7f5c587e8d80a0b27611 (patch)
tree8ee244cbf567bf03169e875a7cbc2493380a1418
parentd2f828fbf3955f8072b8d2d02a73ccad4c1b9a67 (diff)
downloadsubsurface-38d70ba8545e9c97c60d7f5c587e8d80a0b27611.tar.gz
cleanup: un-slotify QMLManager functions
Some slots in QMLManager were not called from the outside, some only directly from C++-code. Make the former private and the latter public member functions. The idea here is to document which functions are actually called from the outside and which are called from QML or connected to signals. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r--mobile-widgets/qmlmanager.h10
1 files changed, 5 insertions, 5 deletions
diff --git a/mobile-widgets/qmlmanager.h b/mobile-widgets/qmlmanager.h
index 29f7109c6..79c4f23ad 100644
--- a/mobile-widgets/qmlmanager.h
+++ b/mobile-widgets/qmlmanager.h
@@ -152,6 +152,8 @@ public:
void setBtEnabled(bool value);
void setShowNonDiveComputers(bool show);
+ qreal lastDevicePixelRatio();
+ void setDevicePixelRatio(qreal dpr, QScreen *screen);
void setDiveListProcessing(bool value);
@@ -174,7 +176,6 @@ public slots:
void appInitialized();
void applicationStateChanged(Qt::ApplicationState state);
void saveCloudCredentials(const QString &email, const QString &password, const QString &pin);
- void loadDivesWithValidCredentials();
void commitChanges(QString diveId, QString number, QString date, QString location, QString gps,
QString duration, QString depth, QString airtemp,
QString watertemp, QString suit, QString buddy,
@@ -222,12 +223,8 @@ public slots:
QString getGpsFromSiteName(const QString& siteName);
QString getVersion() const;
void deleteGpsFix(quint64 when);
- void revertToNoCloudIfNeeded();
- void consumeFinishedLoad();
void refreshDiveList();
void screenChanged(QScreen *screen);
- qreal lastDevicePixelRatio();
- void setDevicePixelRatio(qreal dpr, QScreen *screen);
void appendTextToLog(const QString &newText);
void quit();
void hasLocationSourceChanged();
@@ -280,6 +277,9 @@ private:
QAction *undoAction;
bool verifyCredentials(QString email, QString password, QString pin);
+ void loadDivesWithValidCredentials();
+ void revertToNoCloudIfNeeded();
+ void consumeFinishedLoad();
#if defined(Q_OS_ANDROID) || defined(Q_OS_IOS)
QString appLogFileName;