aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-04-29 07:34:48 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-05-11 12:06:19 -0700
commit743f217620d8758af658ecfd3f8960ebed0a1427 (patch)
treed939c885af99bef07b0acc86f1a8ed24071a1f70
parent144de49ad45eb882ecfaf4257c20999e4efd1db1 (diff)
downloadsubsurface-743f217620d8758af658ecfd3f8960ebed0a1427.tar.gz
Map: don't call exitEditMode() in MapWidget::reload()
On reload of the map, the map exits edit mode. Sounds logical at first, but the whole map-mode code is very unpredictable. What happened was that when switching from the dive site table to dive site edit mode, the code would enter map edit mode first. Then, the dive site tab got its hide-signal, which would reset the filter. This would reload the map and thus exit mode. Hence the user can't drag the flag on the map. Partially fixes #2076 Reported-by: Doug Junkins <junkins@foghead.com> Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r--desktop-widgets/mapwidget.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/desktop-widgets/mapwidget.cpp b/desktop-widgets/mapwidget.cpp
index 5ae7451ee..b06100c50 100644
--- a/desktop-widgets/mapwidget.cpp
+++ b/desktop-widgets/mapwidget.cpp
@@ -86,7 +86,6 @@ void MapWidget::repopulateLabels()
void MapWidget::reload()
{
CHECK_IS_READY_RETURN_VOID();
- m_mapHelper->exitEditMode();
if (!skipReload)
m_mapHelper->reloadMapLocations();
}