aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-11-28 15:49:49 +0100
committerGravatar bstoeger <32835590+bstoeger@users.noreply.github.com>2019-12-04 13:00:23 +0100
commit75dac8906ec0e9b0d1a3cad24ab89bf033bafbf9 (patch)
tree02e289a636bc94f0f1af7add9f41a1e085785c63
parent364a8270d1089dcd8f3efb411568be273aa0b59a (diff)
downloadsubsurface-75dac8906ec0e9b0d1a3cad24ab89bf033bafbf9.tar.gz
Cleanup: remove toggle parameter from DiveListView::selectDive()
This defaulted to false and no caller used anything different. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r--desktop-widgets/divelistview.cpp10
-rw-r--r--desktop-widgets/divelistview.h4
2 files changed, 6 insertions, 8 deletions
diff --git a/desktop-widgets/divelistview.cpp b/desktop-widgets/divelistview.cpp
index f1c816e63..9a9bd3604 100644
--- a/desktop-widgets/divelistview.cpp
+++ b/desktop-widgets/divelistview.cpp
@@ -322,13 +322,11 @@ QList<dive_trip_t *> DiveListView::selectedTrips()
return ret;
}
-void DiveListView::selectDive(QModelIndex idx, bool scrollto, bool toggle)
+void DiveListView::selectDive(QModelIndex idx, bool scrollto)
{
if (!idx.isValid())
return;
- QItemSelectionModel::SelectionFlags flags = toggle ? QItemSelectionModel::Toggle : QItemSelectionModel::Select;
- flags |= QItemSelectionModel::Rows;
- selectionModel()->setCurrentIndex(idx, flags);
+ selectionModel()->setCurrentIndex(idx, QItemSelectionModel::Select | QItemSelectionModel::Rows);
if (idx.parent().isValid()) {
setAnimated(false);
expand(idx.parent());
@@ -341,7 +339,7 @@ void DiveListView::selectDive(QModelIndex idx, bool scrollto, bool toggle)
selectionChangeDone();
}
-void DiveListView::selectDive(int i, bool scrollto, bool toggle)
+void DiveListView::selectDive(int i, bool scrollto)
{
if (i == -1)
return;
@@ -350,7 +348,7 @@ void DiveListView::selectDive(int i, bool scrollto, bool toggle)
if (match.isEmpty())
return;
QModelIndex idx = match.first();
- selectDive(idx, scrollto, toggle);
+ selectDive(idx, scrollto);
}
void DiveListView::selectDives(const QList<int> &newDiveSelection)
diff --git a/desktop-widgets/divelistview.h b/desktop-widgets/divelistview.h
index 9cb2bd66a..f4738e346 100644
--- a/desktop-widgets/divelistview.h
+++ b/desktop-widgets/divelistview.h
@@ -31,8 +31,8 @@ public:
bool eventFilter(QObject *, QEvent *);
void unselectDives();
void clearTripSelection();
- void selectDive(QModelIndex index, bool scrollto = false, bool toggle = false);
- void selectDive(int dive_table_idx, bool scrollto = false, bool toggle = false);
+ void selectDive(QModelIndex index, bool scrollto = false);
+ void selectDive(int dive_table_idx, bool scrollto = false);
void selectDives(const QList<int> &newDiveSelection);
void contextMenuEvent(QContextMenuEvent *event);
QList<dive_trip *> selectedTrips();