aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Jan Mulder <jlmulder@xs4all.nl>2018-11-24 11:53:15 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-01-22 13:02:39 +1300
commit94fa9358183464297e05fcd68aeb293e1c80a1ba (patch)
treeba65e9b44a797425f408fd367616ceae0369522f
parent1e0ac92dd7a1362da2f73f29966c6cf54002f2ec (diff)
downloadsubsurface-94fa9358183464297e05fcd68aeb293e1c80a1ba.tar.gz
Android build: add explanation for huge hack
This had to be embedded in the build process (or better, solved for real). Using Cmake, Clang, NDK 18b, Qt 5.12 beta 4, some Subsurface code does not compile. At this point in time, its fully unclear to me why we see the error as it is. Thing fail deep down in Qt and NDK headers on #include <cmath>. Error like "::signbit is not in the global namespace". The most logic reason is an improper order in which include paths are constructed in the build process. Any attempt to find the real reason failed. Even very similar command lines from a qmake build that succeed fail with a cmake style build. The very very dirty hack is commenting out some lines in NDK 18b: "./android-ndk-r18b/sources/cxx-stl/llvm-libc++/include/cmath Comment lines 313-325, and all build, links and runs with no errors related to this known at this point. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
-rw-r--r--packaging/android/warning-ndk18b.txt21
1 files changed, 21 insertions, 0 deletions
diff --git a/packaging/android/warning-ndk18b.txt b/packaging/android/warning-ndk18b.txt
new file mode 100644
index 000000000..64d49ef52
--- /dev/null
+++ b/packaging/android/warning-ndk18b.txt
@@ -0,0 +1,21 @@
+WARNING
+-------
+
+Using Cmake, Clang, NDK 18b, Qt 5.12 beta 4, some Subsurface code does
+not compile. At this point in time, its fully unclear to me why we see the
+error as it is.
+
+Thing fail deep down in Qt and NDK headers on #include <cmath>. Error like
+"::signbit is not in the global namespace". The most logic reason is an
+improper order in which include paths are constructed in the build process.
+Any attempt to find the real reason failed. Even very similar command lines
+from a qmake build that succeed fail with a cmake style build.
+
+The very very dirty hack is commenting out some lines in NDK 18b:
+
+"./android-ndk-r18b/sources/cxx-stl/llvm-libc++/include/cmath
+
+Comment lines 313-325, and all build, links and runs with no errors
+related to this known at this point.
+
+Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>