diff options
author | Dirk Hohndel <dirk@hohndel.org> | 2020-01-02 15:34:46 -0800 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2020-01-04 02:47:45 +0900 |
commit | ab71f5daca696e23a4ad63a475c1a43219633c29 (patch) | |
tree | 645b259bb0354861737d1de7d75de5f06beaf8f0 | |
parent | d0e52140e586e4f9537738177d54400a855b7d2b (diff) | |
download | subsurface-ab71f5daca696e23a4ad63a475c1a43219633c29.tar.gz |
GitHub Actions: change passwords to be hard coded
As much as I hate having passwords exposed through the source code,
since GitHub wisely prevents reading secrets in pull requests, there
isn't really a sane way to have this use confidential credentials.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
-rw-r--r-- | .github/workflows/linux-bionic-5.9.yml | 2 | ||||
-rw-r--r-- | .github/workflows/linux-eoan-5.12.yml | 7 | ||||
-rw-r--r-- | .github/workflows/mac.yml | 4 |
3 files changed, 5 insertions, 8 deletions
diff --git a/.github/workflows/linux-bionic-5.9.yml b/.github/workflows/linux-bionic-5.9.yml index c0cba7b49..46cebc764 100644 --- a/.github/workflows/linux-bionic-5.9.yml +++ b/.github/workflows/linux-bionic-5.9.yml @@ -37,7 +37,7 @@ jobs: - name: test desktop build env: SSRF_USER_EMAIL: ssrftest-u18@hohndel.org - SSRF_USER_PASSWORD: ${{ secrets.cloudu18 }} + SSRF_USER_PASSWORD: geheim-u18 run: | # and now run the tests - with Qt 5.9 we can only run the desktop flavor echo "------------------------------------" diff --git a/.github/workflows/linux-eoan-5.12.yml b/.github/workflows/linux-eoan-5.12.yml index 276e72cc1..299bc72f1 100644 --- a/.github/workflows/linux-eoan-5.12.yml +++ b/.github/workflows/linux-eoan-5.12.yml @@ -18,9 +18,6 @@ jobs: uses: actions/checkout@v1 - name: get container ready for build - env: - SSRF_USER_EMAIL: ssrftest-u19@hohndel.org - SSRF_USER_PASSWORD: ${{ secrets.cloudu19 }} run: | echo "--------------------------------------------------------------" echo "update distro and install dependencies" @@ -49,7 +46,7 @@ jobs: - name: test mobile build env: SSRF_USER_EMAIL: ssrftest-u19@hohndel.org - SSRF_USER_PASSWORD: ${{ secrets.cloudu19 }} + SSRF_USER_PASSWORD: geheim-u19 run: | echo "--------------------------------------------------------------" echo "running tests for mobile" @@ -69,7 +66,7 @@ jobs: - name: test desktop build env: SSRF_USER_EMAIL: ssrftest-u19@hohndel.org - SSRF_USER_PASSWORD: ${{ secrets.cloudu19 }} + SSRF_USER_PASSWORD: geheim-u19 run: | echo "--------------------------------------------------------------" echo "running tests for desktop" diff --git a/.github/workflows/mac.yml b/.github/workflows/mac.yml index 72440c24f..d3889ab20 100644 --- a/.github/workflows/mac.yml +++ b/.github/workflows/mac.yml @@ -35,7 +35,7 @@ jobs: - name: test mobile build env: SSRF_USER_EMAIL: ssrftest-mac@hohndel.org - SSRF_USER_PASSWORD: ${{ secrets.cloudmac }} + SSRF_USER_PASSWORD: geheim-mac run: | echo "------------------------------------" echo "run tests for mobile build" @@ -64,7 +64,7 @@ jobs: - name: test desktop build env: SSRF_USER_EMAIL: ssrftest-mac@hohndel.org - SSRF_USER_PASSWORD: ${{ secrets.cloudmac }} + SSRF_USER_PASSWORD: geheim-mac run: | echo "------------------------------------" echo "run tests for desktop build" |