aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Jan Mulder <jlmulder@xs4all.nl>2018-11-24 11:53:15 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-12-30 11:20:34 -0800
commitcdee2fde6480549195c819c0dd484883cb4b5d95 (patch)
tree1fc0fb05db23814767b642c696261a36aa0d509f
parent2bed16203fe74045cf52ba325798dca65f6e37e0 (diff)
downloadsubsurface-cdee2fde6480549195c819c0dd484883cb4b5d95.tar.gz
Android build: add explanation for huge hack
This had to be embedded in the build process (or better, solved for real). Using Cmake, Clang, NDK 18b, Qt 5.12 beta 4, some Subsurface code does not compile. At this point in time, its fully unclear to me why we see the error as it is. Thing fail deep down in Qt and NDK headers on #include <cmath>. Error like "::signbit is not in the global namespace". The most logic reason is an improper order in which include paths are constructed in the build process. Any attempt to find the real reason failed. Even very similar command lines from a qmake build that succeed fail with a cmake style build. The very very dirty hack is commenting out some lines in NDK 18b: "./android-ndk-r18b/sources/cxx-stl/llvm-libc++/include/cmath Comment lines 313-325, and all build, links and runs with no errors related to this known at this point. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
-rw-r--r--packaging/android/warning-ndk18b.txt21
1 files changed, 21 insertions, 0 deletions
diff --git a/packaging/android/warning-ndk18b.txt b/packaging/android/warning-ndk18b.txt
new file mode 100644
index 000000000..64d49ef52
--- /dev/null
+++ b/packaging/android/warning-ndk18b.txt
@@ -0,0 +1,21 @@
+WARNING
+-------
+
+Using Cmake, Clang, NDK 18b, Qt 5.12 beta 4, some Subsurface code does
+not compile. At this point in time, its fully unclear to me why we see the
+error as it is.
+
+Thing fail deep down in Qt and NDK headers on #include <cmath>. Error like
+"::signbit is not in the global namespace". The most logic reason is an
+improper order in which include paths are constructed in the build process.
+Any attempt to find the real reason failed. Even very similar command lines
+from a qmake build that succeed fail with a cmake style build.
+
+The very very dirty hack is commenting out some lines in NDK 18b:
+
+"./android-ndk-r18b/sources/cxx-stl/llvm-libc++/include/cmath
+
+Comment lines 313-325, and all build, links and runs with no errors
+related to this known at this point.
+
+Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>