aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2020-04-12 12:20:25 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2020-05-03 14:47:49 -0700
commitd520ac22864fed77f44de9461c3bb5302b22e30f (patch)
treefb72fcbe29e4d6acfd62f63c5b6a341d38d1f644
parent8f8457ebe4b01b42bdb7545b7a782f35bf207134 (diff)
downloadsubsurface-d520ac22864fed77f44de9461c3bb5302b22e30f.tar.gz
cleanup: remove parameter to ProfleWidget2::replot()
Firstly, the parameter appears conceptually wrong, as replot suggests that the currently shown dive is replot. Secondly, the only caller that passed a parameter was passing in current_dive, which is just what happens if one doesn't pass a parameter. Therefore, change that caller (call plotDive directly) and remove the parameter. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
-rw-r--r--desktop-widgets/mainwindow.cpp2
-rw-r--r--profile-widget/profilewidget2.cpp4
-rw-r--r--profile-widget/profilewidget2.h2
3 files changed, 4 insertions, 4 deletions
diff --git a/desktop-widgets/mainwindow.cpp b/desktop-widgets/mainwindow.cpp
index cb1179d8c..a0a0dded0 100644
--- a/desktop-widgets/mainwindow.cpp
+++ b/desktop-widgets/mainwindow.cpp
@@ -783,7 +783,7 @@ void MainWindow::refreshProfile()
{
showProfile();
configureToolbar();
- graphics->replot(current_dive);
+ graphics->plotDive(current_dive, true);
DivePictureModel::instance()->updateDivePictures();
}
diff --git a/profile-widget/profilewidget2.cpp b/profile-widget/profilewidget2.cpp
index 365f4758d..b516b1544 100644
--- a/profile-widget/profilewidget2.cpp
+++ b/profile-widget/profilewidget2.cpp
@@ -379,10 +379,10 @@ void ProfileWidget2::setupItemOnScene()
gasYAxis->setZValue(timeAxis->zValue() + 1);
}
-void ProfileWidget2::replot(struct dive *d)
+void ProfileWidget2::replot()
{
dataModel->clear();
- plotDive(d, true, false);
+ plotDive(nullptr, true, false);
}
void ProfileWidget2::createPPGas(PartialPressureGasItem *item, int verticalColumn, color_index_t color, color_index_t colorAlert,
diff --git a/profile-widget/profilewidget2.h b/profile-widget/profilewidget2.h
index e00bda074..6461f83ef 100644
--- a/profile-widget/profilewidget2.h
+++ b/profile-widget/profilewidget2.h
@@ -108,7 +108,7 @@ slots: // Necessary to call from QAction's signals.
void actionRequestedReplot(bool triggered);
void setEmptyState();
void setProfileState();
- void replot(dive *d = 0);
+ void replot();
#ifndef SUBSURFACE_MOBILE
void plotPictures();
void removePictures(const QVector<QString> &fileUrls);