diff options
| author |  Linus Torvalds <torvalds@linux-foundation.org> | 2016-04-11 11:36:31 -0700 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2016-04-11 12:23:05 -0700 |
| commit | effad4b2c8c1b929125e499af3071232aee59938 (patch) | |
| tree | 33d12e7bb9cb5f37f42ffb98a07b4b3212d2ccf7 | |
| parent | ccff22759612455ba5b4eb7232b6b8d50177ba4a (diff) | |
| download | subsurface-effad4b2c8c1b929125e499af3071232aee59938.tar.gz | |
Fix seabear import sample overrun bug
The Seabear import fixed up the NDL and TTS in the samples from minutes
(in the import) to seconds (our internal format for all time). But it
did it with a loop that overran the end of the samples array by one:
for(int s_nr = 0 ; s_nr <= dive->dc.samples ; s_nr++) {
Fix it to use the proper "<" instead of "<=".
Reported-by: Stuart Vernon <stuartv@force2.net>
Tested-by: Miika Turkia <miika.turkia@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
| -rw-r--r-- | desktop-widgets/divelogimportdialog.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/desktop-widgets/divelogimportdialog.cpp b/desktop-widgets/divelogimportdialog.cpp index cd9026f87..757cad59e 100644 --- a/desktop-widgets/divelogimportdialog.cpp +++ b/desktop-widgets/divelogimportdialog.cpp @@ -782,7 +782,7 @@ void DiveLogImportDialog::on_buttonBox_accepted() } // Seabear CSV stores NDL and TTS in Minutes, not seconds struct dive *dive = dive_table.dives[dive_table.nr - 1]; - for(int s_nr = 0 ; s_nr <= dive->dc.samples ; s_nr++) { + for(int s_nr = 0 ; s_nr < dive->dc.samples ; s_nr++) { struct sample *sample = dive->dc.sample + s_nr; sample->ndl.seconds *= 60; sample->tts.seconds *= 60; |