diff options
author | Dirk Hohndel <dirk@hohndel.org> | 2020-02-07 14:55:23 -0800 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2020-02-08 10:29:36 -0800 |
commit | fb057b7094b4cdef3456b8dad3ed653d99125fe8 (patch) | |
tree | 94f5bc7181d2cb982a9053775036665a88baba09 | |
parent | 5f6b7450a9f8a2cfebe03d939cbc66a982bee680 (diff) | |
download | subsurface-fb057b7094b4cdef3456b8dad3ed653d99125fe8.tar.gz |
mobile/summary: improve the spacing of the content
Use more idiomatic ways to indent the rows, replace the TemplateLabel with a
simple Label since drawing the extra rectangle for the background of the
TemplateLabel is obviously redundant and using it doesn't change the number
of properties we need to set.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
-rw-r--r-- | mobile-widgets/qml/DiveSummary.qml | 34 |
1 files changed, 20 insertions, 14 deletions
diff --git a/mobile-widgets/qml/DiveSummary.qml b/mobile-widgets/qml/DiveSummary.qml index 21a5f3305..612cee9fd 100644 --- a/mobile-widgets/qml/DiveSummary.qml +++ b/mobile-widgets/qml/DiveSummary.qml @@ -12,7 +12,7 @@ Kirigami.ScrollablePage { DiveSummaryModel { id: summaryModel } property string firstDive: "" property string lastDive: "" - property int headerColumnWidth: Math.floor(width / 4) + property int headerColumnWidth: Math.floor(width / 3) background: Rectangle { color: subsurfaceTheme.backgroundColor } title: qsTr("Dive summary") @@ -118,13 +118,18 @@ Kirigami.ScrollablePage { Row { height: headerLabel.height + Kirigami.Units.largeSpacing Rectangle { + width: Kirigami.Units.gridUnit * 2 + height: parent.height + color: "transparent" + } + Rectangle { color: index & 1 ? subsurfaceTheme.backgroundColor : subsurfaceTheme.lightPrimaryColor width: headerColumnWidth height: headerLabel.height + Kirigami.Units.largeSpacing - TemplateLabel { + Label { id: headerLabel + color: subsurfaceTheme.textColor anchors.verticalCenter: parent.verticalCenter - colorBackground: parent.color leftPadding: Kirigami.Units.largeSpacing text: header !== undefined ? header : "" font.bold: true @@ -132,21 +137,21 @@ Kirigami.ScrollablePage { } Rectangle { color: index & 1 ? subsurfaceTheme.backgroundColor : subsurfaceTheme.lightPrimaryColor - width: headerColumnWidth * 1.5 - Kirigami.Units.gridUnit + width: headerColumnWidth - 2 * Kirigami.Units.gridUnit height: headerLabel.height + Kirigami.Units.largeSpacing - TemplateLabel { + Label { + color: subsurfaceTheme.textColor anchors.verticalCenter: parent.verticalCenter - colorBackground: parent.color text: col0 !== undefined ? col0 : "" } } Rectangle { color: index & 1 ? subsurfaceTheme.backgroundColor : subsurfaceTheme.lightPrimaryColor - width: headerColumnWidth * 1.5 - Kirigami.Units.gridUnit + width: headerColumnWidth - 2 * Kirigami.Units.gridUnit height: headerLabel.height + Kirigami.Units.largeSpacing - TemplateLabel { + Label { + color: subsurfaceTheme.textColor anchors.verticalCenter: parent.verticalCenter - colorBackground: parent.color text: col1 !== undefined ? col1 : "" } } @@ -156,12 +161,13 @@ Kirigami.ScrollablePage { Component { id: sectionDelegate Rectangle { - width: headerColumnWidth * 4 - Kirigami.Units.gridUnit * 2 - height: headerLabel.height + Kirigami.Units.largeSpacing - TemplateLabel { - id: headerLabel + width: headerColumnWidth * 3 - Kirigami.Units.gridUnit * 2 + height: sectionLabel.height + Kirigami.Units.largeSpacing + Label { + id: sectionLabel anchors.verticalCenter: parent.verticalCenter - colorBackground: parent.color + leftPadding: Kirigami.Units.largeSpacing + color: subsurfaceTheme.textColor text: section font.bold: true } |