diff options
| author |  Dirk Hohndel <dirk@hohndel.org> | 2019-03-19 08:22:51 -0700 |
|---|---|---|
| committer | Dirk Hohndel <dirk@hohndel.org> | 2019-04-04 15:17:06 -0700 |
| commit | f1371adbb87dbfd37d5cc6619aac5b733df0d0e2 (patch) | |
| tree | 51dc990eec60cea910765c595e37bf1d86060900 /core/configuredivecomputerthreads.cpp | |
| parent | 43fb4ef36b3f1b1a5c651f6342b475a9a6ed023a (diff) | |
| download | subsurface-f1371adbb87dbfd37d5cc6619aac5b733df0d0e2.tar.gz | |
Misc: replace some FIXME comments
All these aren't actually things that need fixing, they are observations about
the code.
Given that LGTM.com reports FIXME comments as Alerts, let's change the ones
that aren't about things that need fixing to something more harmless.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'core/configuredivecomputerthreads.cpp')
| -rw-r--r-- | core/configuredivecomputerthreads.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/configuredivecomputerthreads.cpp b/core/configuredivecomputerthreads.cpp index 7ca00b917..9b9374c58 100644 --- a/core/configuredivecomputerthreads.cpp +++ b/core/configuredivecomputerthreads.cpp @@ -1442,7 +1442,7 @@ static dc_status_t read_ostc_settings(dc_device_t *device, DeviceDetails *m_devi unsigned char data[256] = {}; #ifdef DEBUG_OSTC_CF - // FIXME: how should we report settings not supported back? + // open question: how should we report settings not supported back? unsigned char max_CF = 0; #endif rc = hw_ostc_device_eeprom_read(device, 0, data, sizeof(data)); @@ -1829,7 +1829,7 @@ static dc_status_t write_ostc_settings(dc_device_t *device, DeviceDetails *m_dev else if (gas5.type == 2) data[33] = 5; else - // FIXME: No gas was First? + // odd: No gas was First? // Set gas 1 to first data[33] = 1; @@ -1956,7 +1956,7 @@ static dc_status_t write_ostc_settings(dc_device_t *device, DeviceDetails *m_dev else if (dil5.type == 2) data[115] = 5; else - // FIXME: No first diluent? + // odd: No first diluent? // Set gas 1 to fist data[115] = 1; @@ -2178,7 +2178,7 @@ void WriteSettingsThread::run() } break; case DC_FAMILY_HW_OSTC3: - // FIXME: Is this the best way? + // Is this the best way? if (m_deviceDetails->model == "OSTC 4") rc = write_ostc4_settings(m_data->device, m_deviceDetails, DeviceThread::event_cb, this); else |