aboutsummaryrefslogtreecommitdiffstats
path: root/core/import-suunto.c
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-10-17 22:56:40 +0200
committerGravatar bstoeger <32835590+bstoeger@users.noreply.github.com>2019-10-20 16:20:58 +0200
commit769403a4b2c3dd8e8cc94d7f1b5dad6b66d10caf (patch)
tree0aba021b487e55bb478cce7c4a56eba9d6fc5496 /core/import-suunto.c
parentf7c8d65add1a4b46e847e905bb4ac73e94f9e75a (diff)
downloadsubsurface-769403a4b2c3dd8e8cc94d7f1b5dad6b66d10caf.tar.gz
Planner: copy deco state before passing it to worker thread
The planner has a computeVariations() function that can be run in a worker thread. The code was not thread safe: a deco_state object allocated on the stack of the caller was passed down to the worker thread. It's well possible that the object would go out of scope before the thread run. Therefore, when running in the background, copy the object first and free it in the worker thread. Side note: Qt makes proper memory management again as difficult as possible: You can't pass a std::unique_ptr<> to QtConcurrent::run, because move-only objects are not supported. Not very friendly! Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core/import-suunto.c')
0 files changed, 0 insertions, 0 deletions