diff options
| author |  Rolf Eike Beer <eike@sf-mail.de> | 2019-04-01 22:15:19 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2019-04-12 12:59:17 +0300 |
| commit | c4c8094e32ad78dee558a80584470172f48c45b1 (patch) | |
| tree | 4fede2acf0f1a3cee2182d96b1b3efa33e4fd8ff /core/qthelper.cpp | |
| parent | 2b9ca488fd18dc9d65d42dc5900e120a07e5b3f6 (diff) | |
| download | subsurface-c4c8094e32ad78dee558a80584470172f48c45b1.tar.gz | |
get rid of some foreach and Q_FOREACH constructs
See https://www.kdab.com/goodbye-q_foreach/
This is reduced to the places where the container is const or can be made const
without the need to always introduce an extra variable. Sadly qAsConst (Qt 5.7)
and std::as_const (C++17) are not available in all supported setups.
Also do some minor cleanups along the way.
Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
Diffstat (limited to 'core/qthelper.cpp')
| -rw-r--r-- | core/qthelper.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/core/qthelper.cpp b/core/qthelper.cpp index 1a85d35a7..3738e56f2 100644 --- a/core/qthelper.cpp +++ b/core/qthelper.cpp @@ -1144,7 +1144,7 @@ QStringList imageExtensionFilters() QStringList videoExtensionFilters() { QStringList filters; - foreach (const QString &format, videoExtensionsList) + for (const QString &format: videoExtensionsList) filters.append("*" + format); return filters; } @@ -1506,9 +1506,9 @@ int parse_seabear_header(const char *filename, char **params, int pnr) parseLine = f.readLine().trimmed(); - QStringList currColumns = parseLine.split(';'); + const QStringList currColumns = parseLine.split(';'); unsigned short index = 0; - Q_FOREACH (QString columnText, currColumns) { + for (const QString &columnText: currColumns) { if (columnText == "Time") { params[pnr++] = strdup("timeField"); params[pnr++] = intdup(index++); |