diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2020-03-11 22:21:18 +0100 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2020-03-12 07:09:01 -0700 |
| commit | 7387b10b2944c0126999a3911d6ecf705d243a8b (patch) | |
| tree | 7eaac6f3d6b3bb4ad7fc1ce28b25628d2ede0236 /core | |
| parent | 950ae951bcc948ee632946757e43fca8ce7400fe (diff) | |
| download | subsurface-7387b10b2944c0126999a3911d6ecf705d243a8b.tar.gz | |
cleanup: remove current_dive parameter from divesSelected signal
The diveListNotifier.divesSelected() signal is used to inform the
models of a selection change. It sent the current dive as a second
parameter. This is redundant, because the only sender of the signal
sets current_dive just before sending the signal. Remove the
parameter, which appears to be an artifact.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'core')
| -rw-r--r-- | core/selection.cpp | 2 | ||||
| -rw-r--r-- | core/subsurface-qt/divelistnotifier.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/core/selection.cpp b/core/selection.cpp index 4890f6422..2919f6486 100644 --- a/core/selection.cpp +++ b/core/selection.cpp @@ -192,7 +192,7 @@ void setSelection(const std::vector<dive *> &selection, dive *currentDive) } // Send the new selection - emit diveListNotifier.divesSelected(divesToSelect, current_dive); + emit diveListNotifier.divesSelected(divesToSelect); } extern "C" void select_single_dive(dive *d) diff --git a/core/subsurface-qt/divelistnotifier.h b/core/subsurface-qt/divelistnotifier.h index fc7115a99..5ef25e832 100644 --- a/core/subsurface-qt/divelistnotifier.h +++ b/core/subsurface-qt/divelistnotifier.h @@ -94,7 +94,7 @@ signals: void tripChanged(dive_trip *trip, TripField field); // Selection changes - void divesSelected(const QVector<dive *> &dives, dive *current); + void divesSelected(const QVector<dive *> &dives); // Dive site signals. Add and delete events are sent per dive site and // provide an index into the global dive site table. |