Undo: isolate undo-commands

This refactors the undo-commands (which are now only "commands").

- Move everything in namespace Command. This allows shortening of
  names without polluting the global namespace. Moreover, the prefix
  Command:: will immediately signal that the undo-machinery is
  invoked. This is more terse than UndoCommands::instance()->...
- Remove the Undo in front of the class-names. Creating an "UndoX"
  object to do "X" is paradoxical.
- Create a base class for all commands that defines the Qt-translation
  functions. Thus all translations end up in the "Command" context.
- Add a workToBeDone() function, which signals whether this should be
  added to the UndoStack. Thus the caller doesn't have to check itself
  whether this any work will be done. Note: Qt5.9 introduces "setObsolete"
  which does the same.
- Split into public and internal header files. In the public header
  file only export the function calls, thus hiding all implementation
  details from the caller.
- Split in different translation units: One for the stubs, one for
  the base classes and one for groups of commands. Currently, there
  is only one class of commands: divelist-commands.
- Move the undoStack from the MainWindow class into commands_base.cpp.
  If we want to implement MDI, this can easily be moved into an
  appropriate Document class.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

1 files changed, 106 insertions, 483 deletions

diff --git a/desktop-widgets/command_divelist.cpp b/desktop-widgets/command_divelist.cpp
index 6f638b2a6..d12aebfc2 100644
--- a/desktop-widgets/command_divelist.cpp
+++ b/desktop-widgets/command_divelist.cpp
@@ -4,60 +4,14 @@
 #include "desktop-widgets/mainwindow.h"
 #include "desktop-widgets/divelistview.h"
 #include "core/divelist.h"
-#include "core/display.h" // for amount_selected
-#include "core/subsurface-qt/DiveListNotifier.h"
-#include "qt-models/filtermodels.h"
 
 namespace Command {
 
-// Generally, signals are sent in batches per trip. To avoid writing the same loop
-// again and again, this template takes a vector of trip / dive pairs, sorts it
-// by trip and then calls a function-object with trip and a QVector of dives in that trip.
-// Input parameters:
-//	- dives: a vector of trip,dive pairs, which will be sorted and processed in batches by trip.
-//	- action: a function object, taking a trip-pointer and a QVector of dives, which will be called for each batch.
-template<typename Function>
-void processByTrip(std::vector<std::pair<dive_trip *, dive *>> &dives, Function action)
-{
-	// Use std::tie for lexicographical sorting of trip, then start-time
-	std::sort(dives.begin(), dives.end(),
-		  [](const std::pair<dive_trip *, dive *> &e1, const std::pair<dive_trip *, dive *> &e2)
-		  { return std::tie(e1.first, e1.second->when) < std::tie(e2.first, e2.second->when); });
-
-	// Then, process the dives in batches by trip
-	size_t i, j; // Begin and end of batch
-	for (i = 0; i < dives.size(); i = j) {
-		dive_trip *trip = dives[i].first;
-		for (j = i + 1; j < dives.size() && dives[j].first == trip; ++j)
-			; // pass
-		// Copy dives into a QVector. Some sort of "range_view" would be ideal, but Qt doesn't work this way.
-		QVector<dive *> divesInTrip(j - i);
-		for (size_t k = i; k < j; ++k)
-			divesInTrip[k - i] = dives[k].second;
-
-		// Finally, emit the signal
-		action(trip, divesInTrip);
-	}
-}
-
-
 // This helper function removes a dive, takes ownership of the dive and adds it to a DiveToAdd structure.
 // It is crucial that dives are added in reverse order of deletion, so the the indices are correctly
 // set and that the trips are added before they are used!
-DiveToAdd DiveListBase::removeDive(struct dive *d)
-{
-	// If the dive to be removed is selected, we will inform the frontend
-	// later via a signal that the dive changed.
-	if (d->selected)
-		selectionChanged = true;
-
-	// If the dive was the current dive, reset the current dive. The calling
-	// command is responsible of finding a new dive.
-	if (d == current_dive) {
-		selectionChanged = true; // Should have been set above, as current dive is always selected.
-		current_dive = nullptr;
-	}
-
+static DiveToAdd removeDive(struct dive *d)
+{
 	DiveToAdd res;
 	res.idx = get_divenr(d);
 	if (res.idx < 0)
@@ -72,68 +26,37 @@ DiveToAdd DiveListBase::removeDive(struct dive *d)
 	}
 
 	res.dive.reset(unregister_dive(res.idx));	// Remove dive from backend
-
 	return res;
 }
 
 // This helper function adds a dive and returns ownership to the backend. It may also add a dive trip.
 // It is crucial that dives are added in reverse order of deletion (see comment above)!
 // Returns pointer to added dive (which is owned by the backend!)
-dive *DiveListBase::addDive(DiveToAdd &d)
+static dive *addDive(DiveToAdd &d)
 {
-	if (d.tripToAdd)
-		insert_trip_dont_merge(d.tripToAdd.release()); // Return ownership to backend
+	if (d.tripToAdd) {
+		dive_trip *t = d.tripToAdd.release();	// Give up ownership of trip
+		insert_trip(&t);			// Return ownership to backend
+	}
 	if (d.trip)
 		add_dive_to_trip(d.dive.get(), d.trip);
-	dive *res = d.dive.release();		// Give up ownership of dive
-
-	// Set the filter flag according to current filter settings
-	bool show = MultiFilterSortModel::instance()->showDive(res);
-	res->hidden_by_filter = !show;
-
-	add_single_dive(d.idx, res);		// Return ownership to backend
-
-	// If the dive to be removed is selected, we will inform the frontend
-	// later via a signal that the dive changed.
-	if (res->selected)
-		selectionChanged = true;
-
+	dive *res = d.dive.release();			// Give up ownership of dive
+	add_single_dive(d.idx, res);			// Return ownership to backend
 	return res;
 }
 
 // This helper function calls removeDive() on a list of dives to be removed and
 // returns a vector of corresponding DiveToAdd objects, which can later be readded.
 // The passed in vector is cleared.
-std::vector<DiveToAdd> DiveListBase::removeDives(std::vector<dive *> &divesToDelete)
+static std::vector<DiveToAdd> removeDives(std::vector<dive *> &divesToDelete)
 {
 	std::vector<DiveToAdd> res;
 	res.reserve(divesToDelete.size());
 
-	// First, tell the filters that dives are removed. This could
-	// be done later using the emitted signals, but we do this here
-	// for symmetry with addDives()
-	MultiFilterSortModel::instance()->divesDeleted(QVector<dive *>::fromStdVector(divesToDelete));
-
 	for (dive *d: divesToDelete)
 		res.push_back(removeDive(d));
 	divesToDelete.clear();
 
-	// We send one dives-deleted signal per trip (see comments in DiveListNotifier.h).
-	// Therefore, collect all dives in an array and sort by trip.
-	std::vector<std::pair<dive_trip *, dive *>> dives;
-	dives.reserve(res.size());
-	for (const DiveToAdd &entry: res)
-		dives.push_back({ entry.trip, entry.dive.get() });
-
-	// Send signals.
-	processByTrip(dives, [&](dive_trip *trip, const QVector<dive *> &divesInTrip) {
-		// Now, let's check if this trip is supposed to be deleted, by checking if it was marked
-		// as "add it". We could be smarter here, but let's just check the whole array for brevity.
-		bool deleteTrip = trip &&
-				  std::find_if(res.begin(), res.end(), [trip](const DiveToAdd &entry)
-					       { return entry.tripToAdd.get() == trip; }) != res.end();
-		emit diveListNotifier.divesDeleted(trip, deleteTrip, divesInTrip);
-	});
 	return res;
 }
 
@@ -141,79 +64,29 @@ std::vector<DiveToAdd> DiveListBase::removeDives(std::vector<dive *> &divesToDel
 // of dives to be (re)added and returns a vector of the added dives. It does this in reverse
 // order, so that trips are created appropriately and indexing is correct.
 // The passed in vector is cleared.
-std::vector<dive *> DiveListBase::addDives(std::vector<DiveToAdd> &divesToAdd)
+static std::vector<dive *> addDives(std::vector<DiveToAdd> &divesToAdd)
 {
 	std::vector<dive *> res;
-	res.resize(divesToAdd.size());
-
-	// First, tell the filters that new dives are added. We do this here
-	// instead of later by signals, so that the filter can set the
-	// checkboxes of the new rows to its liking. The added dives will
-	// then appear in the correct shown/hidden state.
-	QVector<dive *> divesForFilter;
-	for (const DiveToAdd &entry: divesToAdd)
-		divesForFilter.push_back(entry.dive.get());
-	MultiFilterSortModel::instance()->divesAdded(divesForFilter);
-
-	// At the end of the function, to send the proper dives-added signals,
-	// we the the list of added trips. Create this list now.
-	std::vector<dive_trip *> addedTrips;
-	for (const DiveToAdd &entry: divesToAdd) {
-		if (entry.tripToAdd)
-			addedTrips.push_back(entry.tripToAdd.get());
-	}
+	res.reserve(divesToAdd.size());
 
-	// Now, add the dives
-	// Note: the idiomatic STL-way would be std::transform, but let's use a loop since
-	// that is closer to classical C-style.
-	auto it2 = res.rbegin();
-	for (auto it = divesToAdd.rbegin(); it != divesToAdd.rend(); ++it, ++it2)
-		*it2 = addDive(*it);
+	for (auto it = divesToAdd.rbegin(); it != divesToAdd.rend(); ++it)
+		res.push_back(addDive(*it));
 	divesToAdd.clear();
 
-	// We send one dives-deleted signal per trip (see comments in DiveListNotifier.h).
-	// Therefore, collect all dives in a array and sort by trip.
-	std::vector<std::pair<dive_trip *, dive *>> dives;
-	dives.reserve(res.size());
-	for (dive *d: res)
-		dives.push_back({ d->divetrip, d });
-
-	// Send signals.
-	processByTrip(dives, [&](dive_trip *trip, const QVector<dive *> &divesInTrip) {
-		// Now, let's check if this trip is supposed to be created, by checking if it was marked
-		// as "add it". We could be smarter here, but let's just check the whole array for brevity.
-		bool createTrip = trip && std::find(addedTrips.begin(), addedTrips.end(), trip) != addedTrips.end();
-		// Finally, emit the signal
-		emit diveListNotifier.divesAdded(trip, createTrip, divesInTrip);
-	});
 	return res;
 }
 
 // This helper function renumbers dives according to an array of id/number pairs.
 // The old numbers are stored in the array, thus calling this function twice has no effect.
 // TODO: switch from uniq-id to indexes once all divelist-actions are controlled by undo-able commands
-static void renumberDives(QVector<QPair<dive *, int>> &divesToRenumber)
+static void renumberDives(QVector<QPair<int, int>> &divesToRenumber)
 {
 	for (auto &pair: divesToRenumber) {
-		dive *d = pair.first;
+		dive *d = get_dive_by_uniq_id(pair.first);
 		if (!d)
 			continue;
 		std::swap(d->number, pair.second);
 	}
-
-	// Emit changed signals per trip.
-	// First, collect all dives and sort by trip
-	std::vector<std::pair<dive_trip *, dive *>> dives;
-	dives.reserve(divesToRenumber.size());
-	for (const auto &pair: divesToRenumber) {
-		dive *d = pair.first;
-		dives.push_back({ d->divetrip, d });
-	}
-
-	// Send signals.
-	processByTrip(dives, [&](dive_trip *trip, const QVector<dive *> &divesInTrip) {
-		emit diveListNotifier.divesChanged(trip, divesInTrip);
-	});
 }
 
 // This helper function moves a dive to a trip. The old trip is recorded in the
@@ -250,16 +123,10 @@ static OwningTripPtr moveDiveToTrip(DiveToTrip &diveToTrip)
 // a no-op.
 static void moveDivesBetweenTrips(DivesToTrip &dives)
 {
-	// We collect an array of created trips so that we can instruct
-	// the model to create a new entry
-	std::vector<dive_trip *> createdTrips;
-	createdTrips.reserve(dives.tripsToAdd.size());
-
-	// First, bring back the trip(s)
+	// first bring back the trip(s)
 	for (OwningTripPtr &trip: dives.tripsToAdd) {
 		dive_trip *t = trip.release();	// Give up ownership
-		createdTrips.push_back(t);
-		insert_trip_dont_merge(t);	// Return ownership to backend
+		insert_trip(&t);		// Return ownership to backend
 	}
 	dives.tripsToAdd.clear();
 
@@ -270,247 +137,22 @@ static void moveDivesBetweenTrips(DivesToTrip &dives)
 			dives.tripsToAdd.push_back(std::move(tripToAdd));
 	}
 
-	// We send one signal per from-trip/to-trip pair.
-	// First, collect all dives in a struct and sort by from-trip/to-trip.
-	struct DiveMoved {
-		dive_trip *from;
-		dive_trip *to;
-		dive *d;
-	};
-	std::vector<DiveMoved> divesMoved;
-	divesMoved.reserve(dives.divesToMove.size());
-	for (const DiveToTrip &entry: dives.divesToMove)
-		divesMoved.push_back({ entry.trip, entry.dive->divetrip, entry.dive });
-
-	// Sort lexicographically by from-trip, to-trip and by start-time.
-	// Use std::tie() for lexicographical sorting.
-	std::sort(divesMoved.begin(), divesMoved.end(), [] ( const DiveMoved &d1, const DiveMoved &d2)
-		  { return std::tie(d1.from, d1.to, d1.d->when) < std::tie(d2.from, d2.to, d2.d->when); });
-
-	// Now, process the dives in batches by trip
-	// TODO: this is a bit different from the cases above, so we don't use the processByTrip template,
-	// but repeat the loop here. We might think about generalizing the template, if more of such
-	// "special cases" appear.
-	size_t i, j; // Begin and end of batch
-	for (i = 0; i < divesMoved.size(); i = j) {
-		dive_trip *from = divesMoved[i].from;
-		dive_trip *to = divesMoved[i].to;
-		for (j = i + 1; j < divesMoved.size() && divesMoved[j].from == from && divesMoved[j].to == to; ++j)
-			; // pass
-		// Copy dives into a QVector. Some sort of "range_view" would be ideal, but Qt doesn't work this way.
-		QVector<dive *> divesInTrip(j - i);
-		for (size_t k = i; k < j; ++k)
-			divesInTrip[k - i] = divesMoved[k].d;
-
-		// Check if the from-trip was deleted: If yes, it was recorded in the tripsToAdd structure
-		bool deleteFrom = from &&
-				  std::find_if(dives.tripsToAdd.begin(), dives.tripsToAdd.end(),
-					       [from](const OwningTripPtr &trip) { return trip.get() == from; }) != dives.tripsToAdd.end();
-		// Check if the to-trip has to be created. For this purpose, we saved an array of trips to be created.
-		bool createTo = false;
-		if (to) {
-			// Check if the element is there...
-			auto it = std::find(createdTrips.begin(), createdTrips.end(), to);
-
-			// ...if it is - remove it as we don't want the model to create the trip twice!
-			if (it != createdTrips.end()) {
-				createTo = true;
-				// erase/remove would be more performant, but this is irrelevant in the big scheme of things.
-				createdTrips.erase(it);
-			}
-		}
-
-		// Finally, emit the signal
-		emit diveListNotifier.divesMovedBetweenTrips(from, to, deleteFrom, createTo, divesInTrip);
-	}
-
 	// Reverse the tripsToAdd and the divesToAdd, so that on undo/redo the operations
 	// will be performed in reverse order.
 	std::reverse(dives.tripsToAdd.begin(), dives.tripsToAdd.end());
 	std::reverse(dives.divesToMove.begin(), dives.divesToMove.end());
 }
 
-// When we initialize the command we don't have to roll-back any selection change
-DiveListBase::DiveListBase() : firstExecution(true)
-{
-}
-
-// Turn current selection into a vector.
-// TODO: This could be made much more efficient if we kept a sorted list of selected dives!
-static std::vector<dive *> getDiveSelection()
-{
-	std::vector<dive *> res;
-	res.reserve(amount_selected);
-
-	int i;
-	dive *d;
-	for_each_dive(i, d) {
-		if (d->selected)
-			res.push_back(d);
-	}
-	return res;
-}
-
-void DiveListBase::initWork()
-{
-	selectionChanged = false;
-}
-
-void DiveListBase::finishWork()
-{
-	if (selectionChanged) // If the selection changed -> tell the frontend
-		emit diveListNotifier.selectionChanged();
-}
-
-// Set the current dive either from a list of selected dives,
-// or a newly selected dive. In both cases, try to select the
-// dive that is newer that is newer than the given date.
-// This mimics the old behavior when the current dive changed.
-static void setClosestCurrentDive(timestamp_t when, const std::vector<dive *> &selection)
-{
-	// Start from back until we get the first dive that is before
-	// the supposed-to-be selected dive. (Note: this mimics the
-	// old behavior when the current dive changed).
-	for (auto it = selection.rbegin(); it < selection.rend(); ++it) {
-		if ((*it)->when > when && !(*it)->hidden_by_filter) {
-			current_dive = *it;
-			return;
-		}
-	}
-
-	// We didn't find a more recent selected dive -> try to
-	// find *any* visible selected dive.
-	for (dive *d: selection) {
-		if (!d->hidden_by_filter) {
-			current_dive = d;
-			return;
-		}
-	}
-
-	// No selected dive is visible! Take the closest dive. Note, this might
-	// return null, but that just means unsetting the current dive (as no
-	// dive is visible anyway).
-	current_dive = find_next_visible_dive(when);
-}
-
-// Rese the selection to the dives of the "selection" vector and send the appropriate signals.
-// Set the current dive to "currentDive". "currentDive" must be an element of "selection" (or
-// null if "seletion" is empty).
-void DiveListBase::restoreSelection(const std::vector<dive *> &selection, dive *currentDive)
-{
-	// To do so, generate vectors of dives to be selected and deselected.
-	// We send signals batched by trip, so keep track of trip/dive pairs.
-	std::vector<std::pair<dive_trip *, dive *>> divesToSelect;
-	std::vector<std::pair<dive_trip *, dive *>> divesToDeselect;
-
-	// TODO: We might want to keep track of selected dives in a more efficient way!
-	int i;
-	dive *d;
-	amount_selected = 0; // We recalculate amount_selected
-	for_each_dive(i, d) {
-		// We only modify dives that are currently visible.
-		if (d->hidden_by_filter) {
-			d->selected = false; // Note, not necessary, just to be sure
-					     // that we get amount_selected right
-			continue;
-		}
-
-		// Search the dive in the list of selected dives.
-		// TODO: By sorting the list in the same way as the backend, this could be made more efficient.
-		bool newState = std::find(selection.begin(), selection.end(), d) != selection.end();
-
-		// TODO: Instead of using select_dive() and deselect_dive(), we set selected directly.
-		// The reason is that deselect() automatically sets a new current dive, which we
-		// don't want, as we set it later anyway.
-		// There is other parts of the C++ code that touches the innards directly, but
-		// ultimately this should be pushed down to C.
-		if (newState && !d->selected) {
-			d->selected = true;
-			++amount_selected;
-			divesToSelect.push_back({ d->divetrip, d });
-		} else if (!newState && d->selected) {
-			d->selected = false;
-			divesToDeselect.push_back({ d->divetrip, d });
-		}
-	}
-
-	// Send the select and deselect signals
-	processByTrip(divesToSelect, [&](dive_trip *trip, const QVector<dive *> &divesInTrip) {
-		emit diveListNotifier.divesSelected(trip, divesInTrip);
-	});
-	processByTrip(divesToDeselect, [&](dive_trip *trip, const QVector<dive *> &divesInTrip) {
-		emit diveListNotifier.divesDeselected(trip, divesInTrip);
-	});
-
-	bool currentDiveChanged = false;
-	if (current_dive != currentDive) {
-		currentDiveChanged = true;
-
-		// We cannot simply change the currentd dive to the given dive.
-		// It might be hidden by a filter and thus not be selected.
-		if (currentDive->selected)
-			// Current dive is visible and selected. Excellent.
-			current_dive = currentDive;
-		else
-			// Current not visible -> find a different dive.
-			setClosestCurrentDive(currentDive->when, selection);
-		emit diveListNotifier.currentDiveChanged();
-	}
-
-	// If anything changed (selection or current dive), send a final signal.
-	if (!divesToSelect.empty() || !divesToDeselect.empty() || currentDiveChanged)
-		selectionChanged = true;
-}
-
-void DiveListBase::undo()
-{
-	auto marker = diveListNotifier.enterCommand();
-	initWork();
-	undoit();
-	finishWork();
-}
-
-void DiveListBase::redo()
-{
-	auto marker = diveListNotifier.enterCommand();
-	initWork();
-	redoit();
-	finishWork();
-}
-
-AddDive::AddDive(dive *d, bool autogroup, bool newNumber)
+AddDive::AddDive(dive *d)
 {
 	setText(tr("add dive"));
-	// By convention, d is "displayed dive" and can be overwritten.
 	d->maxdepth.mm = 0;
-	d->dc.maxdepth.mm = 0;
 	fixup_dive(d);
-
-	// Get an owning pointer to a copied or moved dive
-	// Note: if move is true, this destroys the old dive!
-	OwningDivePtr divePtr(clone_dive(d));
-	divePtr->selected = false; // If we clone a planned dive, it might have been selected.
-				   // We have to clear the flag, as selections will be managed
-				   // on dive-addition.
-
-	// If we alloc a new-trip for autogrouping, get an owning pointer to it.
-	OwningTripPtr allocTrip;
-	dive_trip *trip = divePtr->divetrip;
-	// We have to delete the pointer-to-trip, because this would prevent the core from adding to the trip
-	// and we would get the count-of-dives in the trip wrong. Yes, that's all horribly subtle!
-	divePtr->divetrip = nullptr;
-	if (!trip && autogroup) {
-		bool alloc;
-		trip = get_trip_for_new_dive(divePtr.get(), &alloc);
-		if (alloc)
-			allocTrip.reset(trip);
-	}
-
-	int idx = dive_get_insertion_index(divePtr.get());
-	if (newNumber)
-		divePtr->number = get_dive_nr_at_idx(idx);
-
-	divesToAdd.push_back({ std::move(divePtr), std::move(allocTrip), trip, idx });
+	diveToAdd.trip = d->divetrip;
+	d->divetrip = nullptr;
+	diveToAdd.idx = dive_get_insertion_index(d);
+	d->number = get_dive_nr_at_idx(diveToAdd.idx);
+	diveToAdd.dive.reset(clone_dive(d));
 }
 
 bool AddDive::workToBeDone()
@@ -518,34 +160,24 @@ bool AddDive::workToBeDone()
 	return true;
 }
 
-void AddDive::redoit()
+void AddDive::redo()
 {
-	// Remember selection so that we can undo it
-	selection = getDiveSelection();
-	currentDive = current_dive;
-
-	divesToRemove = addDives(divesToAdd);
+	diveToRemove = addDive(diveToAdd);
 	mark_divelist_changed(true);
 
-	// Select the newly added dive
-	restoreSelection(divesToRemove, divesToRemove[0]);
-
-	// Exit from edit mode, but don't recalculate dive list
-	// TODO: Remove edit mode
-	MainWindow::instance()->refreshDisplay(false);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->dive_list()->unselectDives();
+	MainWindow::instance()->dive_list()->selectDive(diveToAdd.idx, true);
+	MainWindow::instance()->refreshDisplay();
 }
 
-void AddDive::undoit()
+void AddDive::undo()
 {
-	// Simply remove the dive that was previously added...
-	divesToAdd = removeDives(divesToRemove);
-
-	// ...and restore the selection
-	restoreSelection(selection, currentDive);
+	// Simply remove the dive that was previously added
+	diveToAdd = removeDive(diveToRemove);
 
-	// Exit from edit mode, but don't recalculate dive list
-	// TODO: Remove edit mode
-	MainWindow::instance()->refreshDisplay(false);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
 }
 
 DeleteDive::DeleteDive(const QVector<struct dive*> &divesToDeleteIn) : divesToDelete(divesToDeleteIn.toStdVector())
@@ -558,31 +190,23 @@ bool DeleteDive::workToBeDone()
 	return !divesToDelete.empty();
 }
 
-void DeleteDive::undoit()
+void DeleteDive::undo()
 {
 	divesToDelete = addDives(divesToAdd);
+
 	mark_divelist_changed(true);
 
-	// Select all re-added dives and make the first one current
-	dive *currentDive = !divesToDelete.empty() ? divesToDelete[0] : nullptr;
-	restoreSelection(divesToDelete, currentDive);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
 }
 
-void DeleteDive::redoit()
+void DeleteDive::redo()
 {
 	divesToAdd = removeDives(divesToDelete);
 	mark_divelist_changed(true);
 
-	// Deselect all dives and select dive that was close to the first deleted dive
-	dive *newCurrent = nullptr;
-	if (!divesToAdd.empty()) {
-		timestamp_t when = divesToAdd[0].dive->when;
-		newCurrent = find_next_visible_dive(when);
-	}
-	if (newCurrent)
-		restoreSelection(std::vector<dive *>{ newCurrent }, newCurrent);
-	else
-		restoreSelection(std::vector<dive *>(), nullptr);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
 }
 
 
@@ -592,30 +216,20 @@ ShiftTime::ShiftTime(const QVector<dive *> &changedDives, int amount)
 	setText(tr("shift time of %n dives", "", changedDives.count()));
 }
 
-void ShiftTime::redoit()
+void ShiftTime::undo()
 {
 	for (dive *d: diveList)
 		d->when -= timeChanged;
 
 	// Changing times may have unsorted the dive table
 	sort_table(&dive_table);
-
-	// We send one dives-deleted signal per trip (see comments in DiveListNotifier.h).
-	// Therefore, collect all dives in a array and sort by trip.
-	std::vector<std::pair<dive_trip *, dive *>> dives;
-	dives.reserve(diveList.size());
-	for (dive *d: diveList)
-		dives.push_back({ d->divetrip, d });
-
-	// Send signals.
-	processByTrip(dives, [&](dive_trip *trip, const QVector<dive *> &divesInTrip) {
-		emit diveListNotifier.divesTimeChanged(trip, timeChanged, divesInTrip);
-	});
+	mark_divelist_changed(true);
 
 	// Negate the time-shift so that the next call does the reverse
 	timeChanged = -timeChanged;
 
-	mark_divelist_changed(true);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
 }
 
 bool ShiftTime::workToBeDone()
@@ -623,22 +237,25 @@ bool ShiftTime::workToBeDone()
 	return !diveList.isEmpty();
 }
 
-void ShiftTime::undoit()
+void ShiftTime::redo()
 {
-	// Same as redoit(), since after redoit() we reversed the timeOffset
-	redoit();
+	// Same as undo(), since after undo() we reversed the timeOffset
+	undo();
 }
 
 
-RenumberDives::RenumberDives(const QVector<QPair<dive *, int>> &divesToRenumberIn) : divesToRenumber(divesToRenumberIn)
+RenumberDives::RenumberDives(const QVector<QPair<int, int>> &divesToRenumberIn) : divesToRenumber(divesToRenumberIn)
 {
 	setText(tr("renumber %n dive(s)", "", divesToRenumber.count()));
 }
 
-void RenumberDives::undoit()
+void RenumberDives::undo()
 {
 	renumberDives(divesToRenumber);
 	mark_divelist_changed(true);
+
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
 }
 
 bool RenumberDives::workToBeDone()
@@ -646,10 +263,10 @@ bool RenumberDives::workToBeDone()
 	return !divesToRenumber.isEmpty();
 }
 
-void RenumberDives::redoit()
+void RenumberDives::redo()
 {
 	// Redo and undo do the same thing!
-	undoit();
+	undo();
 }
 
 bool TripBase::workToBeDone()
@@ -657,17 +274,20 @@ bool TripBase::workToBeDone()
 	return !divesToMove.divesToMove.empty();
 }
 
-void TripBase::redoit()
+void TripBase::redo()
 {
 	moveDivesBetweenTrips(divesToMove);
 
 	mark_divelist_changed(true);
+
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
 }
 
-void TripBase::undoit()
+void TripBase::undo()
 {
 	// Redo and undo do the same thing!
-	redoit();
+	redo();
 }
 
 RemoveDivesFromTrip::RemoveDivesFromTrip(const QVector<dive *> &divesToRemove)
@@ -748,18 +368,14 @@ SplitDives::SplitDives(dive *d, duration_t time)
 		split_dive_dont_insert(d, &new1, &new2) :
 		split_dive_at_time_dont_insert(d, time, &new1, &new2);
 
-	// If this didn't work, simply return. Empty arrays indicate that nothing is to be done.
-	if (idx < 0)
+	// If this didn't work, reset pointers so that redo() and undo() do nothing
+	if (idx < 0) {
+		diveToSplit = nullptr;
+		divesToUnsplit[0] = divesToUnsplit[1];
 		return;
+	}
 
-	// Currently, the core code selects the dive -> this is not what we want, as
-	// we manually manage the selection post-command.
-	// TODO: Reset selection in core.
-	new1->selected = false;
-	new2->selected = false;
-
-	diveToSplit.push_back(d);
-	splitDives.resize(2);
+	diveToSplit = d;
 	splitDives[0].dive.reset(new1);
 	splitDives[0].trip = d->divetrip;
 	splitDives[0].idx = idx;
@@ -770,34 +386,45 @@ SplitDives::SplitDives(dive *d, duration_t time)
 
 bool SplitDives::workToBeDone()
 {
-	return !diveToSplit.empty();
+	return !!diveToSplit;
 }
 
-void SplitDives::redoit()
+void SplitDives::redo()
 {
-	divesToUnsplit = addDives(splitDives);
-	unsplitDive = removeDives(diveToSplit);
+	if (!diveToSplit)
+		return;
+	divesToUnsplit[0] = addDive(splitDives[0]);
+	divesToUnsplit[1] = addDive(splitDives[1]);
+	unsplitDive = removeDive(diveToSplit);
 	mark_divelist_changed(true);
 
-	// Select split dives and make first dive current
-	restoreSelection(divesToUnsplit, divesToUnsplit[0]);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
+	MainWindow::instance()->refreshProfile();
 }
 
-void SplitDives::undoit()
+void SplitDives::undo()
 {
-	// Note: reverse order with respect to redoit()
-	diveToSplit = addDives(unsplitDive);
-	splitDives = removeDives(divesToUnsplit);
+	if (!unsplitDive.dive)
+		return;
+	// Note: reverse order with respect to redo()
+	diveToSplit = addDive(unsplitDive);
+	splitDives[1] = removeDive(divesToUnsplit[1]);
+	splitDives[0] = removeDive(divesToUnsplit[0]);
 	mark_divelist_changed(true);
 
-	// Select unsplit dive and make it current
-	restoreSelection(diveToSplit, diveToSplit[0] );
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
+	MainWindow::instance()->refreshProfile();
 }
 
 MergeDives::MergeDives(const QVector <dive *> &dives)
 {
 	setText(tr("merge dive"));
 
+	// We start in redo mode
+	diveToUnmerge = nullptr;
+
 	// Just a safety check - if there's not two or more dives - do nothing
 	// The caller should have made sure that this doesn't happen.
 	if (dives.count() < 2) {
@@ -808,11 +435,6 @@ MergeDives::MergeDives(const QVector <dive *> &dives)
 	dive_trip *preferred_trip;
 	OwningDivePtr d(merge_dives(dives[0], dives[1], dives[1]->when - dives[0]->when, false, &preferred_trip));
 
-	// Currently, the core code selects the dive -> this is not what we want, as
-	// we manually manage the selection post-command.
-	// TODO: Remove selection code from core.
-	d->selected = false;
-
 	// Set the preferred dive trip, so that for subsequent merges the better trip can be selected
 	d->divetrip = preferred_trip;
 	for (int i = 2; i < dives.count(); ++i) {
@@ -864,41 +486,42 @@ MergeDives::MergeDives(const QVector <dive *> &dives)
 			// Stop renumbering if stuff isn't in order (see also core/divelist.c)
 			if (newnr <= previousnr)
 				break;
-			divesToRenumber.append(QPair<dive *,int>(dive_table.dives[i], newnr));
+			divesToRenumber.append(QPair<int,int>(dive_table.dives[i]->id, newnr));
 			previousnr = newnr;
 		}
 	}
 
-	mergedDive.resize(1);
-	mergedDive[0].dive = std::move(d);
-	mergedDive[0].idx = get_divenr(dives[0]);
-	mergedDive[0].trip = preferred_trip;
+	mergedDive.dive = std::move(d);
+	mergedDive.idx = get_divenr(dives[0]);
+	mergedDive.trip = preferred_trip;
 	divesToMerge = dives.toStdVector();
 }
 
 bool MergeDives::workToBeDone()
 {
-	return !mergedDive.empty();
+	return !!mergedDive.dive;
 }
 
-void MergeDives::redoit()
+void MergeDives::redo()
 {
 	renumberDives(divesToRenumber);
-	diveToUnmerge = addDives(mergedDive);
+	diveToUnmerge = addDive(mergedDive);
 	unmergedDives = removeDives(divesToMerge);
 
-	// Select merged dive and make it current
-	restoreSelection(diveToUnmerge, diveToUnmerge[0]);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
+	MainWindow::instance()->refreshProfile();
 }
 
-void MergeDives::undoit()
+void MergeDives::undo()
 {
 	divesToMerge = addDives(unmergedDives);
-	mergedDive = removeDives(diveToUnmerge);
+	mergedDive = removeDive(diveToUnmerge);
 	renumberDives(divesToRenumber);
 
-	// Select unmerged dives and make first one current
-	restoreSelection(divesToMerge, divesToMerge[0]);
+	// Finally, do the UI stuff:
+	MainWindow::instance()->refreshDisplay();
+	MainWindow::instance()->refreshProfile();
 }
 
 } // namespace Command