Core: remove MAX_CYLINDERS restriction

Instead of using fixed size arrays, use a new cylinder_table structure.
The code copies the weightsystem code, but is significantly more complex
because cylinders are such an integral part of the core.

Two functions to access the cylinders were added:
get_cylinder() and get_or_create_cylinder()
The former does a simple array access and supposes that the cylinder
exists. The latter is used by the parser(s) and if a cylinder with
the given id does not exist, cylinders up to that id are generated.

One point will make C programmers cringe: the cylinder structure is
passed by value. This is due to the way the table-macros work. A
refactoring of the table macros is planned. It has to be noted that
the size of a cylinder_t is 64 bytes, i.e. 8 long words on a 64-bit
architecture, so passing on the stack is probably not even significantly
slower than passing as reference.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

1 files changed, 2 insertions, 2 deletions

diff --git a/desktop-widgets/command_edit.h b/desktop-widgets/command_edit.h
index 489c51046..45fde9e59 100644
--- a/desktop-widgets/command_edit.h
+++ b/desktop-widgets/command_edit.h
@@ -246,7 +246,7 @@ struct PasteState {
 	int rating;
 	int visibility;
 	tag_entry *tags;
-	std::vector<cylinder_t> cylinders;
+	struct cylinder_table cylinders;
 	struct weightsystem_table weightsystems;
 
 	PasteState(dive *d, const dive *data, dive_components what); // Read data from dive data for dive d
@@ -273,7 +273,7 @@ class ReplanDive : public Base {
 	// Exchange these data with current dive
 	timestamp_t when;
 	depth_t maxdepth, meandepth;
-	cylinder_t cylinders[MAX_CYLINDERS];
+	struct cylinder_table cylinders;
 	struct divecomputer dc;
 	char *notes;
 	pressure_t surface_pressure;