aboutsummaryrefslogtreecommitdiffstats
path: root/desktop-widgets/configuredivecomputerdialog.cpp
diff options
context:
space:
mode:
authorGravatar Anton Lundin <glance@acc.umu.se>2016-12-28 21:06:54 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2016-12-28 22:40:18 -0800
commitb511eb104aee9d9105340fd8a54c36303a310679 (patch)
treeef69baefe28969d89bde72a5fc9de68a03f18c05 /desktop-widgets/configuredivecomputerdialog.cpp
parente5fd59feca0ec3161d38f89dd5caaaaeee40f5e9 (diff)
downloadsubsurface-b511eb104aee9d9105340fd8a54c36303a310679.tar.gz
Document quirks with Ostc 4 versions
Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'desktop-widgets/configuredivecomputerdialog.cpp')
-rw-r--r--desktop-widgets/configuredivecomputerdialog.cpp5
1 files changed, 4 insertions, 1 deletions
diff --git a/desktop-widgets/configuredivecomputerdialog.cpp b/desktop-widgets/configuredivecomputerdialog.cpp
index 9ee8a0b5b..a91c7d1bc 100644
--- a/desktop-widgets/configuredivecomputerdialog.cpp
+++ b/desktop-widgets/configuredivecomputerdialog.cpp
@@ -258,8 +258,11 @@ void OstcFirmwareCheck::checkLatest(QWidget *_parent, device_data_t *data)
if (latestFirmwareAvailable.isEmpty())
return;
- // for now libdivecomputer gives us the firmware on device undecoded as integer
+ // libdivecomputer gives us the firmware on device as an integer
// for the OSTC that means highbyte.lowbyte is the version number
+ // For OSTC 4's there is actually a another minor, x.y.Z, but its not
+ // exposed via libdivecomputer, so we won't trigger this update flow
+ // when the Z changes
int firmwareOnDevice = devData.libdc_firmware;
QString firmwareOnDeviceString = QString("%1.%2").arg(firmwareOnDevice / 256).arg(firmwareOnDevice % 256);