aboutsummaryrefslogtreecommitdiffstats
path: root/desktop-widgets/mainwindow.cpp
diff options
context:
space:
mode:
authorGravatar Tomaz Canabrava <tcanabrava@kde.org>2017-04-04 19:21:30 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2017-04-06 18:23:25 -0700
commit1fc4fba69fed8607d9b961086a88bcf362a482a5 (patch)
treed063efda90ddcd0324f648ab4be48d2282f5c1ff /desktop-widgets/mainwindow.cpp
parent8a71196e4e58dfb3534fda5f00856a0223726689 (diff)
downloadsubsurface-1fc4fba69fed8607d9b961086a88bcf362a482a5.tar.gz
Break down MainTab into smaller classes
Maintab is one of our most complex classes, and it's something I'm not actually proud of. But it currently works and the idea of splitting it was in my head for quite a while. This is the third or fourth tentative of splitting it, and this time I let the most complex part of it untouched, the Notes and Equipment tab are way too complex to untangle right now on my limited time. A new class 'TabBase' should be used for any new tab that we may create, and added on the MainTab (see the new lines on the MainTab constructor). Also, Extra Info, Information, Photos and Statistics where ported to this new way helping reduce the number of lines and functions on the MainTab quite a bit. Overall this is a step in the right direction for the future. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'desktop-widgets/mainwindow.cpp')
-rw-r--r--desktop-widgets/mainwindow.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/desktop-widgets/mainwindow.cpp b/desktop-widgets/mainwindow.cpp
index 28bc6cee6..5f70fa2e3 100644
--- a/desktop-widgets/mainwindow.cpp
+++ b/desktop-widgets/mainwindow.cpp
@@ -24,7 +24,7 @@
#include "profile-widget/profilewidget2.h"
#include "desktop-widgets/globe.h"
#include "core/divecomputer.h"
-#include "desktop-widgets/maintab.h"
+#include "desktop-widgets/tab-widgets/maintab.h"
#include "desktop-widgets/diveplanner.h"
#ifndef NO_PRINTING
#include <QPrintDialog>
@@ -643,9 +643,7 @@ ProfileWidget2 *MainWindow::graphics() const
void MainWindow::cleanUpEmpty()
{
- information()->clearStats();
- information()->clearInfo();
- information()->clearEquipment();
+ information()->clearTabs();
information()->updateDiveInfo(true);
graphics()->setEmptyState();
dive_list()->reload(DiveTripModel::TREE);