aboutsummaryrefslogtreecommitdiffstats
path: root/desktop-widgets/mapwidget.h
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-08-30 16:51:59 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-09-06 11:48:47 -0700
commitb39f2406c6a520f0b3743324744f3c55914adc52 (patch)
tree8cfadbb34be79cf9e75d2280b70fc1d887380f49 /desktop-widgets/mapwidget.h
parentcabe70be8079a69e159d46525fc8b283d9ec7c2a (diff)
downloadsubsurface-b39f2406c6a520f0b3743324744f3c55914adc52.tar.gz
Map: don't fully reset model on selection change
When changing the selection the MapLocationModel was reset. This lead to crashes on Qt-5.9 which are due to QML accessing data that was freed during model reset. This putative Qt bug doesn't happen on newer Qt versions. At least Qt-5.12 is known to work. Instead of fighting the bug, let's simply not reset the model but send a dataChanged() for every element of the MapLocationModel. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/mapwidget.h')
-rw-r--r--desktop-widgets/mapwidget.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/desktop-widgets/mapwidget.h b/desktop-widgets/mapwidget.h
index bc9303166..9e05ce48f 100644
--- a/desktop-widgets/mapwidget.h
+++ b/desktop-widgets/mapwidget.h
@@ -23,6 +23,7 @@ public:
static MapWidget *instance();
void reload();
+ void selectionChanged();
bool editMode() const;
public slots: