aboutsummaryrefslogtreecommitdiffstats
path: root/desktop-widgets/modeldelegates.cpp
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2019-04-27 17:27:37 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2019-04-29 13:06:39 -0700
commit7b83eeadfff33c709fc7c905b1b339524b5c810b (patch)
tree694ad0e8b749bf3e11b8c3593ed9240f170240ef /desktop-widgets/modeldelegates.cpp
parentcab0147093b829d971ca0a1ce92e9d881440311f (diff)
downloadsubsurface-7b83eeadfff33c709fc7c905b1b339524b5c810b.tar.gz
Cleanup: fix leak in delegates
A copy of a C-string was assigned to a QString. The copy was never freed. Instead, assign the C-string directly. This does the right thing. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/modeldelegates.cpp')
-rw-r--r--desktop-widgets/modeldelegates.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/desktop-widgets/modeldelegates.cpp b/desktop-widgets/modeldelegates.cpp
index 1099ebb69..297a963a5 100644
--- a/desktop-widgets/modeldelegates.cpp
+++ b/desktop-widgets/modeldelegates.cpp
@@ -294,7 +294,7 @@ QWidget *TankInfoDelegate::createEditor(QWidget *parent, const QStyleOptionViewI
QWidget *delegate = ComboBoxDelegate::createEditor(parent, option, index);
CylindersModel *mymodel = qobject_cast<CylindersModel *>(currCombo.model);
cylinder_t *cyl = mymodel->cylinderAt(index);
- currCylinderData.type = copy_string(cyl->type.description);
+ currCylinderData.type = cyl->type.description;
currCylinderData.pressure = cyl->type.workingpressure.mbar;
currCylinderData.size = cyl->type.size.mliter;
MainWindow::instance()->graphics->setReplot(false);
@@ -372,7 +372,7 @@ QWidget *WSInfoDelegate::createEditor(QWidget *parent, const QStyleOptionViewIte
QWidget *editor = ComboBoxDelegate::createEditor(parent, option, index);
WeightModel *mymodel = qobject_cast<WeightModel *>(currCombo.model);
weightsystem_t *ws = mymodel->weightSystemAt(index);
- currWeight.type = copy_string(ws->description);
+ currWeight.type = ws->description;
currWeight.weight = ws->weight.grams;
return editor;
}