diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-05-16 15:25:57 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2018-05-17 07:24:54 -0700 |
| commit | 45395fd466a8d71a1600cf182d08d4aa45d3b892 (patch) | |
| tree | 77311abd1b6fc2382f29fc5da1775858e3c3fbdd /desktop-widgets/printer.cpp | |
| parent | f54268e527764dac4893ad68703a7fa67c2d1ecb (diff) | |
| download | subsurface-45395fd466a8d71a1600cf182d08d4aa45d3b892.tar.gz | |
Dive pictures: Don't plot pictures twice when changing current dive
In MainWindow::current_dive_changed() first plotDive() is called,
which replots all the pictures by calling plotPictures(). This
is pointess, because it plots the pictures of the previous dive.
Then, updateDiveInfo() is called, which resets the dive pictures
and automatically replots them. Thus, switching between dives
both with hundreds of pictures is way slower than necessary.
Switching the plotDive() and updateDiveInfo() calls doesn't work.
The reason is not 100% clear, but it doesn't make sense to plot
pictures of the new dive as long as the profile still shows the
old dive anyway.
As a quick-fix, add a flag to plotDive(), which tells the function
to clear the pictures list instead of redrawing it.
Ultimately, plotDive() should probably be split in two functions.
One for the callers who update the pictures themselves and one
for the others.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/printer.cpp')
| -rw-r--r-- | desktop-widgets/printer.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/desktop-widgets/printer.cpp b/desktop-widgets/printer.cpp index 7381b5f7f..2d1a1d258 100644 --- a/desktop-widgets/printer.cpp +++ b/desktop-widgets/printer.cpp @@ -41,7 +41,7 @@ void Printer::putProfileImage(QRect profilePlaceholder, QRect viewPort, QPainter int y = profilePlaceholder.y() - viewPort.y(); // use the placeHolder and the viewPort position to calculate the relative position of the dive profile. QRect pos(x, y, profilePlaceholder.width(), profilePlaceholder.height()); - profile->plotDive(dive, true); + profile->plotDive(dive, true, true); if (!printOptions->color_selected) { QImage image(pos.width(), pos.height(), QImage::Format_ARGB32); @@ -204,7 +204,7 @@ void Printer::render(int Pages = 0) prefs.animation_speed = animationOriginal; //replot the dive after returning the settings - profile->plotDive(0, true); + profile->plotDive(0, true, true); } //value: ranges from 0 : 100 and shows the progress of the templating engine |