aboutsummaryrefslogtreecommitdiffstats
path: root/desktop-widgets/simplewidgets.cpp
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-07-30 20:41:33 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-07-30 12:20:26 -0700
commit5e1e6110ce50b33e24667ce83ab5d2417a2a466e (patch)
tree8a5bea4ca9463904b6d4d8b786793d39a8f02dfe /desktop-widgets/simplewidgets.cpp
parentd3f3d82abdaabebf5a8c83a57cc6b9e0b7aab1de (diff)
downloadsubsurface-5e1e6110ce50b33e24667ce83ab5d2417a2a466e.tar.gz
Cleanup: remove parameter from currentDiveChanged signal
The currentDiveChanged signal was emitted by the DiveListView to inform the MainWindow of a change of current dive. The new current dive was passed as a parameter. The slot in MainWindow then called select_dive() on the dive. This seems pointless because: 1) In both emits, selected_dive dive was passed as argument. But MainWindow can read this global variable itself. 2) Calling select_dive() again is a no-op, because obviously, this already *was* the selected dive. Moreover it seems conceptually wrong to set the current dive in the slot that is informed of the change of the current dive. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/simplewidgets.cpp')
0 files changed, 0 insertions, 0 deletions