cleanup: un-singletonize ShiftTimesDialog

There is no reason that this dialog is a singleton. Since it is modal,
it can be created on demand. Apart from removing superfluous global state,
this simplifies code, because preparing the widget can now be done in
the constructor instead of overriding the showEvent() function.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

1 files changed, 1 insertions, 3 deletions

diff --git a/desktop-widgets/simplewidgets.h b/desktop-widgets/simplewidgets.h
index ce8c636f7..ed364e75f 100644
--- a/desktop-widgets/simplewidgets.h
+++ b/desktop-widgets/simplewidgets.h
@@ -78,15 +78,13 @@ private:
 class ShiftTimesDialog : public QDialog {
 	Q_OBJECT
 public:
-	static ShiftTimesDialog *instance();
-	void showEvent(QShowEvent *event);
+	explicit ShiftTimesDialog(QWidget *parent);
 private
 slots:
 	void buttonClicked(QAbstractButton *button);
 	void changeTime();
 
 private:
-	explicit ShiftTimesDialog(QWidget *parent);
 	int64_t when;
 	Ui::ShiftTimesDialog ui;
 };