aboutsummaryrefslogtreecommitdiffstats
path: root/desktop-widgets/undocommands.h
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-07-31 07:41:19 +0200
committerGravatar Tomaz Canabrava <tcanabrava@kde.org>2018-07-31 11:02:34 +0200
commitdf156a56c08a56eb380711a507ef739d8150a71f (patch)
tree0d0da57857fff1ba844c84fbc5de2e6cd872cb1e /desktop-widgets/undocommands.h
parent7fe76a5dbdef4a833122e0311191dd51896575f4 (diff)
downloadsubsurface-df156a56c08a56eb380711a507ef739d8150a71f.tar.gz
Cleanup: replace virtual by override where appropriate
The keyword "virtual" signalizes that the function is virtual, i.e. the function of the derived class is called, even if the call is on the parent class. It is not necessary to repeat the "virtual" keyword in derived classes. To highlight derived virtual functions, the keyword "override" should be used instead. It results in a hard compile- error, if no function is overridden, thus avoiding subtle bugs. Replace "virtual" by "override" where appropriate. Moreover, replace Q_DECL_OVERRIDE by override, since we require reasonably recent compilers anyway. Likewise, replace /* reimp */ by "override" for consistency and compiler support. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets/undocommands.h')
-rw-r--r--desktop-widgets/undocommands.h16
1 files changed, 8 insertions, 8 deletions
diff --git a/desktop-widgets/undocommands.h b/desktop-widgets/undocommands.h
index 1403b23bb..4e485e5ed 100644
--- a/desktop-widgets/undocommands.h
+++ b/desktop-widgets/undocommands.h
@@ -8,8 +8,8 @@
class UndoDeleteDive : public QUndoCommand {
public:
UndoDeleteDive(QList<struct dive*> deletedDives);
- virtual void undo();
- virtual void redo();
+ void undo() override;
+ void redo() override;
private:
QList<struct dive*> diveList;
@@ -19,8 +19,8 @@ private:
class UndoShiftTime : public QUndoCommand {
public:
UndoShiftTime(QList<int> changedDives, int amount);
- virtual void undo();
- virtual void redo();
+ void undo() override;
+ void redo() override;
private:
QList<int> diveList;
@@ -30,8 +30,8 @@ private:
class UndoRenumberDives : public QUndoCommand {
public:
UndoRenumberDives(QMap<int, QPair<int, int> > originalNumbers);
- virtual void undo();
- virtual void redo();
+ void undo() override;
+ void redo() override;
private:
QMap<int,QPair<int, int> > oldNumbers;
@@ -40,8 +40,8 @@ private:
class UndoRemoveDivesFromTrip : public QUndoCommand {
public:
UndoRemoveDivesFromTrip(QMap<struct dive*, dive_trip*> removedDives);
- virtual void undo();
- virtual void redo();
+ void undo() override;
+ void redo() override;
private:
QMap<struct dive*, dive_trip*> divesToUndo;