diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2020-10-25 11:45:27 +0100 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2020-10-25 13:59:52 -0700 |
| commit | 4aa571d5a09e7c114633dc046bb8a61044a05d63 (patch) | |
| tree | eb8a30aaa449fe80d322b8f370922f922dbb82dd /desktop-widgets | |
| parent | 464dd93fe8266e3d0af706a6809f09611bd9f83c (diff) | |
| download | subsurface-4aa571d5a09e7c114633dc046bb8a61044a05d63.tar.gz | |
cleanup: remove get_times() functions
The function
1) was misnamed: it determined the time of the first selcted dive.
2) had only one caller.
3) would crash if there was no selected dive.
Let's just fold the functionality into the caller. It's a one-liner
anyway.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'desktop-widgets')
| -rw-r--r-- | desktop-widgets/simplewidgets.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/desktop-widgets/simplewidgets.cpp b/desktop-widgets/simplewidgets.cpp index 6eaab2eef..943da56c3 100644 --- a/desktop-widgets/simplewidgets.cpp +++ b/desktop-widgets/simplewidgets.cpp @@ -193,9 +193,11 @@ void ShiftTimesDialog::buttonClicked(QAbstractButton *button) } ui.timeEdit->setTime(QTime(0, 0, 0, 0)); - when = get_times(); //get time of first selected dive - ui.currentTime->setText(get_dive_date_string(when)); - ui.shiftedTime->setText(get_dive_date_string(when)); + dive *d = first_selected_dive(); + if (d) { + ui.currentTime->setText(get_dive_date_string(d->when)); + ui.shiftedTime->setText(get_dive_date_string(d->when)); + } } void ShiftTimesDialog::changeTime() |