aboutsummaryrefslogtreecommitdiffstats
path: root/export-html.cpp
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2021-02-13 18:58:14 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2021-02-13 12:20:25 -0800
commit622e9ba373f898a0d51fc009f3615d83ffd3a7fc (patch)
tree7dbddb9cd826328d745fe5086e254a93950efab3 /export-html.cpp
parent6ef4f377f0a6bc567f82fa34764c1d81cdab5a1a (diff)
downloadsubsurface-622e9ba373f898a0d51fc009f3615d83ffd3a7fc.tar.gz
printing: "fix" progress indicator
In TemplateLayout, there was a progress indication, which reported the progress - not of the actual rendering - but of adding the dives to the "to render" list. Which is of course done in less than a ms, making the whole thing completely pointless. Instead, emit progress when actually looping over the dives or statistics. Nobody ever noticed the problem because even rendering is done in fractions of a second and indeed is accounted to only one fifth of the total progress. The real purpose of this "fix" is to get rid of the getTotalWork() function, which was just insane. Instead of asking the TemplateLayout how many dives it rendered, this number was extracted from global state. Simply store the number of dives in the TemplateLayout object instead. Moreover, fix two coding style issues: - "Page" variable identifier starting with a capital - The Printer::render() being defined (as opposed to declared) with a default parameter. This is not how C++'s default parameters work, sorry. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'export-html.cpp')
0 files changed, 0 insertions, 0 deletions