diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2020-12-29 23:03:38 +0100 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2021-01-10 15:57:39 -0800 |
| commit | 9560dbf8db668da7abf0490cd42ef416dfe65072 (patch) | |
| tree | 4780b727fb1dcb62998815cb03d1016eae3b116d /profile-widget/profilewidget2.h | |
| parent | f5e60b9618ce514686b487739af4a7690c28d1a2 (diff) | |
| download | subsurface-9560dbf8db668da7abf0490cd42ef416dfe65072.tar.gz | |
profile: unconditionally replot chart when settings change
The code tried to only replot the profile if necessary, notably
when in edit mode or the ceilings are shown.
That seems like pointless premature optimization, which only
complicates things: The profile is replot every time a
"dive handle" is moved, which means that we depend on the
replotting being reasonably fast. Why should it then not
be redrawn if the settings change?
Let's remove this, as it makes control flow easier to reason
about.
This makes the isPlotZoomed member variable redundant. Remove it.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'profile-widget/profilewidget2.h')
| -rw-r--r-- | profile-widget/profilewidget2.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/profile-widget/profilewidget2.h b/profile-widget/profilewidget2.h index 50c1fe91a..5c6e95be5 100644 --- a/profile-widget/profilewidget2.h +++ b/profile-widget/profilewidget2.h @@ -184,7 +184,6 @@ private: #ifndef SUBSURFACE_MOBILE ToolTipItem *toolTipItem; #endif - bool isPlotZoomed; // All those here should probably be merged into one structure, // So it's esyer to replicate for more dives later. // In the meantime, keep it here. |