diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2019-08-25 12:21:37 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2019-08-28 07:12:01 -0700 |
| commit | b3fd824d189056b845452d57fb967a2b50550921 (patch) | |
| tree | 5af4d2bb079936bdf2202a282d7c6bfb3789c203 /qt-models/maplocationmodel.cpp | |
| parent | 25b30da2446d9daf8343c246056b207d285582e7 (diff) | |
| download | subsurface-b3fd824d189056b845452d57fb967a2b50550921.tar.gz | |
Map: catch null divesites in map widget selection code
Just to be sure, refuse to add null divesites to the selection.
Moreover, refuse to call the setSelected function on a null-divesite.
I got an unfriendly Qt-Warning there:
"Passing incompatible arguments to C++ functions from JavaScript is
dangerous and deprecated."
"This will throw a JavaScript TypeError in future releases of Qt!"
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models/maplocationmodel.cpp')
| -rw-r--r-- | qt-models/maplocationmodel.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/qt-models/maplocationmodel.cpp b/qt-models/maplocationmodel.cpp index 1acea421e..da0ec7337 100644 --- a/qt-models/maplocationmodel.cpp +++ b/qt-models/maplocationmodel.cpp @@ -196,6 +196,8 @@ void MapLocationModel::reload(QObject *map) void MapLocationModel::setSelected(struct dive_site *ds, bool fromClick) { m_selectedDs.clear(); + if (!ds) + return; m_selectedDs.append(ds); if (fromClick) emit selectedLocationChanged(getMapLocation(ds)); |