diff options
author | Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2018-02-25 13:51:41 +0100 |
---|---|---|
committer | Lubomir I. Ivanov <neolit123@gmail.com> | 2018-03-14 13:55:36 +0200 |
commit | b72cc1f31784346884c8552c22f1e4c3c6d5ed1d (patch) | |
tree | 00a04967dc56ccdc69ee998058c13911292ecef7 /qt-models/messagehandlermodel.cpp | |
parent | 4e44fe7598430f9879736ec2d00b99b15dc05451 (diff) | |
download | subsurface-b72cc1f31784346884c8552c22f1e4c3c6d5ed1d.tar.gz |
Cleanup: consistently use qPrintable()
Replace constructs of the kind
s.toUtf8().data(),
s.toUtf8().constData(),
s.toLocal8Bit().data(),
s.toLocal8Bit.constData() or
qUtf8Printable(s)
by
qPrintable(s).
This is concise, consistent and - in principle - more performant than
the .data() versions.
Sadly, owing to a suboptimal implementation, qPrintable(s) currently
is a pessimization compared to s.toUtf8().data(). A fix is scheduled for
new Qt versions: https://codereview.qt-project.org/#/c/221331/
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models/messagehandlermodel.cpp')
-rw-r--r-- | qt-models/messagehandlermodel.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/qt-models/messagehandlermodel.cpp b/qt-models/messagehandlermodel.cpp index d783a3da6..e14aaf89c 100644 --- a/qt-models/messagehandlermodel.cpp +++ b/qt-models/messagehandlermodel.cpp @@ -42,7 +42,7 @@ void MessageHandlerModel::addLog(QtMsgType type, const QString& message) beginInsertRows(QModelIndex(), rowCount(), rowCount()); m_data.append({message, type}); endInsertRows(); - INFO("%s", message.toUtf8().constData()); + INFO("%s", qPrintable(message)); #if defined (Q_OS_ANDROID) writeToAppLogFile(message); #endif |