diff options
| author |  Rolf Eike Beer <eike@sf-mail.de> | 2019-04-01 22:15:19 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2019-04-12 12:59:17 +0300 |
| commit | c4c8094e32ad78dee558a80584470172f48c45b1 (patch) | |
| tree | 4fede2acf0f1a3cee2182d96b1b3efa33e4fd8ff /subsurface-helper.cpp | |
| parent | 2b9ca488fd18dc9d65d42dc5900e120a07e5b3f6 (diff) | |
| download | subsurface-c4c8094e32ad78dee558a80584470172f48c45b1.tar.gz | |
get rid of some foreach and Q_FOREACH constructs
See https://www.kdab.com/goodbye-q_foreach/
This is reduced to the places where the container is const or can be made const
without the need to always introduce an extra variable. Sadly qAsConst (Qt 5.7)
and std::as_const (C++17) are not available in all supported setups.
Also do some minor cleanups along the way.
Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
Diffstat (limited to 'subsurface-helper.cpp')
| -rw-r--r-- | subsurface-helper.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/subsurface-helper.cpp b/subsurface-helper.cpp index 786c2ab03..291a3e3bf 100644 --- a/subsurface-helper.cpp +++ b/subsurface-helper.cpp @@ -76,8 +76,8 @@ void run_ui() // same directory the executable was started from <bundle>/Contents/MacOS/ // To work around this we need to manually copy the components at install time // to Contents/Frameworks/qml and make sure that we add the correct import path - QStringList importPathList = engine.importPathList(); - Q_FOREACH (QString importPath, importPathList) { + const QStringList importPathList = engine.importPathList(); + for (QString importPath: importPathList) { if (importPath.contains("MacOS")) engine.addImportPath(importPath.replace("MacOS", "Frameworks")); } |