diff options
| author |  Linus Torvalds <torvalds@linux-foundation.org> | 2019-04-14 14:24:24 -0700 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2019-04-15 11:22:44 +1200 |
| commit | 606c3a02451cb41b984528cbf98ecd9a3f91401f (patch) | |
| tree | 154ce143cdbc38d249f73d8957385fb1698c1659 /subsurface.desktop | |
| parent | 88a9b8abf54f74f44fb709326c551019143cb135 (diff) | |
| download | subsurface-606c3a02451cb41b984528cbf98ecd9a3f91401f.tar.gz | |
make sure to clear dives on dive split failure
The dive splitting code returns an error code when splitting fails, but
it turns out that the C++ UI code doesn't actually look at the error
code, and instead expected the resulting dives to be NULL if an error
happened and the split didn't succeed for whatever reason.
Which is kind of lazy of it, but we might as well clear the resulting
dives and make the UI code happy. This should fix the problem that
Celia Marlowe reported on the Subsurface google groups forum.
Reported-by: Celia Marlowe
Acked-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Fixes: 145f70aab5 ("Undo: implement split-out of dive computer")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'subsurface.desktop')
0 files changed, 0 insertions, 0 deletions