diff options
| author |  Dirk Hohndel <dirk@hohndel.org> | 2021-04-10 17:40:30 -0700 |
|---|---|---|
| committer | Dirk Hohndel <dirk@hohndel.org> | 2021-04-19 12:51:01 -0700 |
| commit | c5eb806adb345e24b13ac4bf106cceb1dc9d3431 (patch) | |
| tree | a071c9dede0640e23dd8032e6b1d0863d85b983e /tests/testgitstorage.cpp | |
| parent | da6395a4a8b68978caf47f98b48a82fabbe1dd20 (diff) | |
| download | subsurface-c5eb806adb345e24b13ac4bf106cceb1dc9d3431.tar.gz | |
cloudstorage: some cleanup of cloud url handling
We know the preference is never empty, so stop testing for this. But
don't maintain two different preferences with basically the same
content. Instead add the '/git' suffix where needed and keep this all in
one place.
Simplify the extraction of the branch name from the cloud URL.
Also a typo fix and a new comment.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'tests/testgitstorage.cpp')
| -rw-r--r-- | tests/testgitstorage.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tests/testgitstorage.cpp b/tests/testgitstorage.cpp index f916b4e40..95ad3c308 100644 --- a/tests/testgitstorage.cpp +++ b/tests/testgitstorage.cpp @@ -111,14 +111,13 @@ void TestGitStorage::initTestCase() if (gitUrl.right(1) != "/") gitUrl += "/"; gitUrl += "git"; - prefs.cloud_git_url = copy_qstring(gitUrl); prefs.cloud_storage_email_encoded = copy_qstring(email); prefs.cloud_storage_password = copy_qstring(password); gitUrl += "/" + email; // all user storage for historical reasons always uses the user's email both as // repo name and as branch. To allow us to keep testing and not step on parallel // runs we'll use actually random branch names - yes, this still has a chance of - // conflict, but I'm not going to implement a distributed locak manager for this + // conflict, but I'm not going to implement a distributed lock manager for this if (email.startsWith("gitstorage")) { #if QT_VERSION >= QT_VERSION_CHECK(5, 10, 0) randomBranch = QString::number(QRandomGenerator::global()->bounded(0x1000000), 16) + |