5 files changed, 105 insertions, 59 deletions

diff --git a/core/divecomputer.cpp b/core/divecomputer.cpp
index e4081e1cd..5a79f3981 100644
--- a/core/divecomputer.cpp
+++ b/core/divecomputer.cpp
@@ -1,12 +1,9 @@
 #include "divecomputer.h"
 #include "dive.h"
+#include "subsurface-qt/SettingsObjectWrapper.h"
 
 #include <QSettings>
 
-const char *default_dive_computer_vendor;
-const char *default_dive_computer_product;
-const char *default_dive_computer_device;
-int default_dive_computer_download_mode;
 DiveComputerList dcList;
 
 DiveComputerList::DiveComputerList()
@@ -144,60 +141,14 @@ extern "C" void call_for_each_dc (void *f, void (*callback)(void *, const char *
 
 extern "C" int is_default_dive_computer(const char *vendor, const char *product)
 {
-	return default_dive_computer_vendor && !strcmp(vendor, default_dive_computer_vendor) &&
-	       default_dive_computer_product && !strcmp(product, default_dive_computer_product);
+	auto dc = SettingsObjectWrapper::instance()->dive_computer_settings;
+	return dc->dc_vendor() == vendor && dc->dc_product() == product;
 }
 
 extern "C" int is_default_dive_computer_device(const char *name)
 {
-	return default_dive_computer_device && !strcmp(name, default_dive_computer_device);
-}
-
-void set_default_dive_computer(const char *vendor, const char *product)
-{
-	QSettings s;
-
-	if (!vendor || !*vendor)
-		return;
-	if (!product || !*product)
-		return;
-	if (is_default_dive_computer(vendor, product))
-		return;
-
-	free((void *)default_dive_computer_vendor);
-	free((void *)default_dive_computer_product);
-	default_dive_computer_vendor = strdup(vendor);
-	default_dive_computer_product = strdup(product);
-	s.beginGroup("DiveComputer");
-	s.setValue("dive_computer_vendor", vendor);
-	s.setValue("dive_computer_product", product);
-	s.endGroup();
-}
-
-void set_default_dive_computer_device(const char *name)
-{
-	QSettings s;
-
-	if (!name || !*name)
-		return;
-	if (is_default_dive_computer_device(name))
-		return;
-
-	free((void *)default_dive_computer_device);
-	default_dive_computer_device = strdup(name);
-	s.beginGroup("DiveComputer");
-	s.setValue("dive_computer_device", name);
-	s.endGroup();
-}
-
-void set_default_dive_computer_download_mode(int download_mode)
-{
-	QSettings s;
-
-	default_dive_computer_download_mode = download_mode;
-	s.beginGroup("DiveComputer");
-	s.setValue("dive_computer_download_mode", download_mode);
-	s.endGroup();
+	auto dc = SettingsObjectWrapper::instance()->dive_computer_settings;
+	return dc->dc_device() == name;
 }
 
 extern "C" void set_dc_nickname(struct dive *dive)
diff --git a/core/helpers.h b/core/helpers.h
index b9f7f50ca..a4a903ea6 100644
--- a/core/helpers.h
+++ b/core/helpers.h
@@ -22,9 +22,6 @@ QString get_volume_string(volume_t volume, bool showunit = false);
 QString get_volume_unit();
 QString get_pressure_string(pressure_t pressure, bool showunit = false);
 QString get_pressure_unit();
-void set_default_dive_computer(const char *vendor, const char *product);
-void set_default_dive_computer_device(const char *name);
-void set_default_dive_computer_download_mode(int downloadMode);
 QString getSubsurfaceDataPath(QString folderToFind);
 QString getPrintingTemplatePathUser();
 QString getPrintingTemplatePathBundle();
diff --git a/core/pref.h b/core/pref.h
index 304bc0b63..c6c30878d 100644
--- a/core/pref.h
+++ b/core/pref.h
@@ -49,6 +49,13 @@ typedef struct {
 	char *next_check;
 } update_manager_prefs_t;
 
+typedef struct {
+	char *vendor;
+	char *product;
+	char *device;
+	int download_mode;
+} dive_computer_prefs_t;
+
 struct preferences {
 	const char *divelist_font;
 	const char *default_filename;
@@ -141,6 +148,7 @@ struct preferences {
 	short cloud_timeout;
 	locale_prefs_t locale; //: TODO: move the rest of locale based info here.
 	update_manager_prefs_t update_manager;
+	dive_computer_prefs_t dive_computer;
 };
 enum unit_system_values {
 	METRIC,
diff --git a/core/subsurface-qt/SettingsObjectWrapper.cpp b/core/subsurface-qt/SettingsObjectWrapper.cpp
index 6d66c9864..7c6001984 100644
--- a/core/subsurface-qt/SettingsObjectWrapper.cpp
+++ b/core/subsurface-qt/SettingsObjectWrapper.cpp
@@ -6,6 +6,65 @@
 
 #include "../dive.h" // TODO: remove copy_string from dive.h
 
+DiveComputerSettings::DiveComputerSettings(QObject *parent):
+	QObject(parent), group(QStringLiteral("DiveComputer"))
+{
+}
+
+QString DiveComputerSettings::dc_vendor() const
+{
+	return prefs.dive_computer.vendor;
+}
+
+QString DiveComputerSettings::dc_product() const
+{
+	return prefs.dive_computer.product;
+}
+
+QString DiveComputerSettings::dc_device() const
+{
+	return prefs.dive_computer.device;
+}
+
+int DiveComputerSettings::downloadMode() const
+{
+	return prefs.dive_computer.download_mode;
+}
+
+void DiveComputerSettings::setVendor(const QString& vendor)
+{
+	QSettings s;
+	s.beginGroup(group);
+	s.setValue("dive_computer_vendor", vendor);
+	free(prefs.dive_computer.vendor);
+	prefs.dive_computer.vendor = copy_string(qPrintable(vendor));
+}
+
+void DiveComputerSettings::setProduct(const QString& product)
+{
+	QSettings s;
+	s.beginGroup(group);
+	s.setValue("dive_computer_product", product);
+	free(prefs.dive_computer.product);
+	prefs.dive_computer.product = copy_string(qPrintable(product));
+}
+
+void DiveComputerSettings::setDevice(const QString& device)
+{
+	QSettings s;
+	s.beginGroup(group);
+	s.setValue("dive_computer_device", device);
+	free(prefs.dive_computer.device);
+	prefs.dive_computer.device = copy_string(qPrintable(device));
+}
+
+void DiveComputerSettings::setDownloadMode(int mode)
+{
+	QSettings s;
+	s.beginGroup(group);
+	s.setValue("dive_computer_download_mode", mode);
+	prefs.dive_computer.download_mode = mode;
+}
 
 UpdateManagerSettings::UpdateManagerSettings(QObject *parent) : QObject(parent), group("UpdateManager")
 {
@@ -1679,7 +1738,8 @@ QObject(parent),
 	language_settings(new LanguageSettingsObjectWrapper(this)),
 	animation_settings(new AnimationsSettingsObjectWrapper(this)),
 	location_settings(new LocationServiceSettingsObjectWrapper(this)),
-	update_manager_settings(new UpdateManagerSettings(this))
+	update_manager_settings(new UpdateManagerSettings(this)),
+	dive_computer_settings(new DiveComputerSettings(this))
 {
 }
 
diff --git a/core/subsurface-qt/SettingsObjectWrapper.h b/core/subsurface-qt/SettingsObjectWrapper.h
index 392bf068b..472150a42 100644
--- a/core/subsurface-qt/SettingsObjectWrapper.h
+++ b/core/subsurface-qt/SettingsObjectWrapper.h
@@ -11,6 +11,34 @@
  * and QWidget frontends. This class will be huge, since
  * I need tons of properties, one for each option. */
 
+class DiveComputerSettings : public QObject {
+	Q_OBJECT
+	Q_PROPERTY(QString vendor READ dc_vendor WRITE setVendor NOTIFY vendorChanged)
+	Q_PROPERTY(QString product READ dc_product WRITE setProduct NOTIFY productChanged)
+	Q_PROPERTY(QString device READ dc_device WRITE setDevice NOTIFY deviceChanged)
+	Q_PROPERTY(int download_mode READ downloadMode WRITE setDownloadMode NOTIFY downloadModeChanged)
+public:
+	DiveComputerSettings(QObject *parent);
+	QString dc_vendor() const;
+	QString dc_product() const;
+	QString dc_device() const;
+	int downloadMode() const;
+
+public slots:
+	void setVendor(const QString& vendor);
+	void setProduct(const QString& product);
+	void setDevice(const QString& device);
+	void setDownloadMode(int mode);
+
+signals:
+	void vendorChanged(const QString& vendor);
+	void productChanged(const QString& product);
+	void deviceChanged(const QString& device);
+	void downloadModeChanged(int mode);
+private:
+	QString group;
+
+};
 class UpdateManagerSettings : public QObject {
 	Q_OBJECT
 	Q_PROPERTY(bool dont_check_for_updates READ dontCheckForUpdates WRITE setDontCheckForUpdates NOTIFY dontCheckForUpdatesChanged)
@@ -647,7 +675,7 @@ class SettingsObjectWrapper : public QObject {
 	Q_PROPERTY(LocationServiceSettingsObjectWrapper* Location  MEMBER location_settings CONSTANT)
 
 	Q_PROPERTY(UpdateManagerSettings* update MEMBER update_manager_settings CONSTANT)
-
+	Q_PROPERTY(DiveComputerSettings* dive_computer MEMBER dive_computer_settings CONSTANT)
 public:
 	static SettingsObjectWrapper *instance();
 
@@ -665,6 +693,8 @@ public:
 	AnimationsSettingsObjectWrapper *animation_settings;
 	LocationServiceSettingsObjectWrapper *location_settings;
 	UpdateManagerSettings *update_manager_settings;
+	DiveComputerSettings *dive_computer_settings;
+
 private:
 	SettingsObjectWrapper(QObject *parent = NULL);
 };